Re: [PATCH 2/6] mm/memblock: make full utilization of numa info

2019-02-27 Thread Pingfan Liu
On Tue, Feb 26, 2019 at 7:58 PM Mike Rapoport wrote: > > On Sun, Feb 24, 2019 at 08:34:05PM +0800, Pingfan Liu wrote: > > There are numa machines with memory-less node. When allocating memory for > > the memory-less node, memblock allocator falls back to 'Node 0' without > > fully > > utilizing

Re: [PATCH 2/6] mm/memblock: make full utilization of numa info

2019-02-26 Thread Dave Hansen
On 2/25/19 9:40 PM, Pingfan Liu wrote: >> This doesn't get used until patch 6 as far as I can tell. Was there a >> reason to define it here? >> > Yes, it gets used until patch 6. Patch 6 has two groups of > pre-requirements [1-2] and [3-5]. Do you think reorder the patches and > moving [3-5]

Re: [PATCH 2/6] mm/memblock: make full utilization of numa info

2019-02-26 Thread Mike Rapoport
On Sun, Feb 24, 2019 at 08:34:05PM +0800, Pingfan Liu wrote: > There are numa machines with memory-less node. When allocating memory for > the memory-less node, memblock allocator falls back to 'Node 0' without fully > utilizing the nearest node. This hurts the performance, especially for per >

Re: [PATCH 2/6] mm/memblock: make full utilization of numa info

2019-02-25 Thread Pingfan Liu
On Mon, Feb 25, 2019 at 11:34 PM Dave Hansen wrote: > > On 2/24/19 4:34 AM, Pingfan Liu wrote: > > +/* > > + * build_node_order() relies on cpumask_of_node(), hence arch should > > + * set up cpumask before calling this func. > > + */ > > Whenever I see comments like this, I wonder what happens

Re: [PATCH 2/6] mm/memblock: make full utilization of numa info

2019-02-25 Thread Dave Hansen
On 2/24/19 4:34 AM, Pingfan Liu wrote: > +/* > + * build_node_order() relies on cpumask_of_node(), hence arch should > + * set up cpumask before calling this func. > + */ Whenever I see comments like this, I wonder what happens if the arch doesn't do this? Do we just crash in early boot in

Re: [PATCH 2/6] mm/memblock: make full utilization of numa info

2019-02-25 Thread kbuild test robot
Hi Pingfan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc4] [cannot apply to next-20190222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/6] mm/memblock: make full utilization of numa info

2019-02-24 Thread kbuild test robot
Hi Pingfan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc4] [cannot apply to next-20190222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 2/6] mm/memblock: make full utilization of numa info

2019-02-24 Thread Pingfan Liu
There are numa machines with memory-less node. When allocating memory for the memory-less node, memblock allocator falls back to 'Node 0' without fully utilizing the nearest node. This hurts the performance, especially for per cpu section. Suppressing this defect by building the full node fall