Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-06-04 Thread Stephen Warren
On 05/29/2015 03:02 PM, Eric Anholt wrote: > Stephen Warren writes: > >> On 05/18/2015 01:43 PM, Eric Anholt wrote: >>> +static struct clk *rpi_firmware_delayed_get_clk(struct >>> of_phandle_args *clkspec, + void *_data) >> >>> + rpi_clk = _clocks[clkspec->args[0]]; + +firmware_node =

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-06-04 Thread Stephen Warren
On 05/29/2015 03:02 PM, Eric Anholt wrote: Stephen Warren swar...@wwwdotorg.org writes: On 05/18/2015 01:43 PM, Eric Anholt wrote: +static struct clk *rpi_firmware_delayed_get_clk(struct of_phandle_args *clkspec, + void *_data) + rpi_clk = rpi_clocks[clkspec-args[0]]; + +

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-29 Thread Eric Anholt
Stephen Warren writes: > On 05/18/2015 01:43 PM, Eric Anholt wrote: >> obj-$(CONFIG_ARCH_BCM2835) += clk-bcm2835.o >> +obj-$(CONFIG_ARCH_BCM2835) += clk-raspberrypi.o > > Shouldn't this replace the old legacy code in clk-bcm2835.c? I don't think we can, because of DT

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-29 Thread Eric Anholt
Stephen Boyd writes: > On 05/28, Stephen Warren wrote: >> On 05/18/2015 01:43 PM, Eric Anholt wrote: >> > Unfortunately, the clock manager's registers are not accessible by the >> > ARM, so we have to request that the firmware modify our clocks for us. >> > >> > This driver only registers the

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-29 Thread Eric Anholt
Stephen Warren writes: > On 05/18/2015 01:43 PM, Eric Anholt wrote: >> +init.flags = CLK_IS_ROOT; > > Is it possible to add clock parent information to the driver, so the > clocks are all hooked together into the correct tree, rather than all > looking like root clocks? > > One of the many

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-29 Thread Eric Anholt
Stephen Boyd sb...@codeaurora.org writes: On 05/28, Stephen Warren wrote: On 05/18/2015 01:43 PM, Eric Anholt wrote: Unfortunately, the clock manager's registers are not accessible by the ARM, so we have to request that the firmware modify our clocks for us. This driver only registers

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-29 Thread Eric Anholt
Stephen Warren swar...@wwwdotorg.org writes: On 05/18/2015 01:43 PM, Eric Anholt wrote: obj-$(CONFIG_ARCH_BCM2835) += clk-bcm2835.o +obj-$(CONFIG_ARCH_BCM2835) += clk-raspberrypi.o Shouldn't this replace the old legacy code in clk-bcm2835.c? I don't think we can, because

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-29 Thread Eric Anholt
Stephen Warren swar...@wwwdotorg.org writes: On 05/18/2015 01:43 PM, Eric Anholt wrote: +init.flags = CLK_IS_ROOT; Is it possible to add clock parent information to the driver, so the clocks are all hooked together into the correct tree, rather than all looking like root clocks? One

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-28 Thread Stephen Boyd
On 05/28, Stephen Warren wrote: > On 05/18/2015 01:43 PM, Eric Anholt wrote: > > Unfortunately, the clock manager's registers are not accessible by the > > ARM, so we have to request that the firmware modify our clocks for us. > > > > This driver only registers the clocks at the point they are

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-28 Thread Stephen Warren
On 05/18/2015 01:43 PM, Eric Anholt wrote: > Unfortunately, the clock manager's registers are not accessible by the > ARM, so we have to request that the firmware modify our clocks for us. > > This driver only registers the clocks at the point they are requested > by a client driver. This is

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-28 Thread Stephen Boyd
On 05/28, Stephen Warren wrote: On 05/18/2015 01:43 PM, Eric Anholt wrote: Unfortunately, the clock manager's registers are not accessible by the ARM, so we have to request that the firmware modify our clocks for us. This driver only registers the clocks at the point they are requested

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-28 Thread Stephen Warren
On 05/18/2015 01:43 PM, Eric Anholt wrote: Unfortunately, the clock manager's registers are not accessible by the ARM, so we have to request that the firmware modify our clocks for us. This driver only registers the clocks at the point they are requested by a client driver. This is

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-18 Thread Baruch Siach
Hi Eric, On Mon, May 18, 2015 at 12:43:34PM -0700, Eric Anholt wrote: > +DEFINE_MUTEX(delayed_clock_init); Static? baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}ooO--U--Ooo{= -

[PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-18 Thread Eric Anholt
Unfortunately, the clock manager's registers are not accessible by the ARM, so we have to request that the firmware modify our clocks for us. This driver only registers the clocks at the point they are requested by a client driver. This is partially to support returning -EPROBE_DEFER when the

[PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-18 Thread Eric Anholt
Unfortunately, the clock manager's registers are not accessible by the ARM, so we have to request that the firmware modify our clocks for us. This driver only registers the clocks at the point they are requested by a client driver. This is partially to support returning -EPROBE_DEFER when the

Re: [PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-18 Thread Baruch Siach
Hi Eric, On Mon, May 18, 2015 at 12:43:34PM -0700, Eric Anholt wrote: +DEFINE_MUTEX(delayed_clock_init); Static? baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}ooO--U--Ooo{= -