On Tue, Aug 27, 2019 at 12:40:02PM +0200, Takashi Iwai wrote:
> On Mon, 26 Aug 2019 19:24:22 +0200,
> Scott Branden wrote:
> >
> > I will admit I am not familiar with every subtlety of PCI
> > accesses. Any comments to the Valkyrie driver in this patch series are
> > appreciated.
> > But not all
On Mon, 26 Aug 2019 19:24:22 +0200,
Scott Branden wrote:
>
> Hi Takashi,
>
> On 2019-08-26 10:12 a.m., Takashi Iwai wrote:
> > On Mon, 26 Aug 2019 17:41:40 +0200,
> > Scott Branden wrote:
> >> HI Takashi,
> >>
> >> On 2019-08-26 8:20 a.m., Takashi Iwai wrote:
> >>> On Fri, 23 Aug 2019 21:44:42
Hi Takashi,
On 2019-08-26 10:12 a.m., Takashi Iwai wrote:
On Mon, 26 Aug 2019 17:41:40 +0200,
Scott Branden wrote:
HI Takashi,
On 2019-08-26 8:20 a.m., Takashi Iwai wrote:
On Fri, 23 Aug 2019 21:44:42 +0200,
Scott Branden wrote:
Hi Takashi,
Thanks for review. comments below.
On
On Mon, 26 Aug 2019 17:41:40 +0200,
Scott Branden wrote:
>
> HI Takashi,
>
> On 2019-08-26 8:20 a.m., Takashi Iwai wrote:
> > On Fri, 23 Aug 2019 21:44:42 +0200,
> > Scott Branden wrote:
> >> Hi Takashi,
> >>
> >> Thanks for review. comments below.
> >>
> >> On 2019-08-23 3:05 a.m., Takashi
On Mon, 26 Aug 2019 17:41:40 +0200,
Scott Branden wrote:
>
> HI Takashi,
>
> On 2019-08-26 8:20 a.m., Takashi Iwai wrote:
> > On Fri, 23 Aug 2019 21:44:42 +0200,
> > Scott Branden wrote:
> >> Hi Takashi,
> >>
> >> Thanks for review. comments below.
> >>
> >> On 2019-08-23 3:05 a.m., Takashi
HI Takashi,
On 2019-08-26 8:20 a.m., Takashi Iwai wrote:
On Fri, 23 Aug 2019 21:44:42 +0200,
Scott Branden wrote:
Hi Takashi,
Thanks for review. comments below.
On 2019-08-23 3:05 a.m., Takashi Iwai wrote:
On Thu, 22 Aug 2019 21:24:46 +0200,
Scott Branden wrote:
Add offset to
On Fri, 23 Aug 2019 21:44:42 +0200,
Scott Branden wrote:
>
> Hi Takashi,
>
> Thanks for review. comments below.
>
> On 2019-08-23 3:05 a.m., Takashi Iwai wrote:
> > On Thu, 22 Aug 2019 21:24:46 +0200,
> > Scott Branden wrote:
> >> Add offset to request_firmware_into_buf to allow for portions
>
Hi Luis,
Thanks for helping on this.
Enjoy your time off an we can work on it when you're back.
comments below.
On 2019-08-23 8:47 a.m., Luis Chamberlain wrote:
On Thu, Aug 22, 2019 at 04:30:37PM -0700, Scott Branden wrote:
On 2019-08-22 2:12 p.m., Luis Chamberlain wrote:
On Thu, Aug 22,
Hi Takashi,
Thanks for review. comments below.
On 2019-08-23 3:05 a.m., Takashi Iwai wrote:
On Thu, 22 Aug 2019 21:24:46 +0200,
Scott Branden wrote:
Add offset to request_firmware_into_buf to allow for portions
of firmware file to be read into a buffer. Necessary where firmware
needs to be
On Thu, Aug 22, 2019 at 04:30:37PM -0700, Scott Branden wrote:
> On 2019-08-22 2:12 p.m., Luis Chamberlain wrote:
> > On Thu, Aug 22, 2019 at 01:07:41PM -0700, Scott Branden wrote:
> > > On 2019-08-22 12:47 p.m., Luis Chamberlain wrote:
> > > > This implies you having to change the other callers,
On Thu, 22 Aug 2019 21:24:46 +0200,
Scott Branden wrote:
>
> Add offset to request_firmware_into_buf to allow for portions
> of firmware file to be read into a buffer. Necessary where firmware
> needs to be loaded in portions from file in memory constrained systems.
AFAIU, this won't work with
Hi Luis,
On 2019-08-22 2:12 p.m., Luis Chamberlain wrote:
On Thu, Aug 22, 2019 at 01:07:41PM -0700, Scott Branden wrote:
On 2019-08-22 12:47 p.m., Luis Chamberlain wrote:
This implies you having to change the other callers, and while currently
our list of drivers is small,
Yes, the list is
On Thu, Aug 22, 2019 at 01:07:41PM -0700, Scott Branden wrote:
> On 2019-08-22 12:47 p.m., Luis Chamberlain wrote:
> > This implies you having to change the other callers, and while currently
> > our list of drivers is small,
>
> Yes, the list is small, very small.
>
> There is a single driver
Hi Luis,
On 2019-08-22 12:47 p.m., Luis Chamberlain wrote:
On Thu, Aug 22, 2019 at 12:24:46PM -0700, Scott Branden wrote:
@@ -923,16 +936,22 @@ EXPORT_SYMBOL_GPL(firmware_request_cache);
*/
int
request_firmware_into_buf(const struct firmware **firmware_p, const char
*name,
-
On Thu, Aug 22, 2019 at 12:24:46PM -0700, Scott Branden wrote:
> @@ -923,16 +936,22 @@ EXPORT_SYMBOL_GPL(firmware_request_cache);
> */
> int
> request_firmware_into_buf(const struct firmware **firmware_p, const char
> *name,
> - struct device *device, void *buf, size_t
Add offset to request_firmware_into_buf to allow for portions
of firmware file to be read into a buffer. Necessary where firmware
needs to be loaded in portions from file in memory constrained systems.
Signed-off-by: Scott Branden
---
drivers/base/firmware_loader/firmware.h | 5 +++
16 matches
Mail list logo
