Re: [PATCH 2/8] regulator: add support for SY8824C regulator

2019-08-28 Thread Mark Brown
On Wed, Aug 28, 2019 at 03:38:29AM +, Jisheng Zhang wrote: > On Tue, 27 Aug 2019 20:44:37 +0100 Mark Brown wrote: > > > > Please send a patch which updates the entire comment block to be > > C++ style so it looks consistent. > Do you mean update the following style > A: > > //

Re: [PATCH 2/8] regulator: add support for SY8824C regulator

2019-08-27 Thread Jisheng Zhang
On Wed, 28 Aug 2019 11:27:05 +0800 Jisheng Zhang wrote: > Hi Mark, > > On Tue, 27 Aug 2019 20:44:37 +0100 Mark Brown wrote: > > > On Tue, Aug 27, 2019 at 08:45:33AM +, Jisheng Zhang wrote: > > > > This looks mostly good and I'll apply it, a couple of small > > things though: > > > > >

Re: [PATCH 2/8] regulator: add support for SY8824C regulator

2019-08-27 Thread Jisheng Zhang
Hi Mark, On Tue, 27 Aug 2019 20:44:37 +0100 Mark Brown wrote: > On Tue, Aug 27, 2019 at 08:45:33AM +, Jisheng Zhang wrote: > > This looks mostly good and I'll apply it, a couple of small > things though: > > > @@ -0,0 +1,192 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + *

Re: [PATCH 2/8] regulator: add support for SY8824C regulator

2019-08-27 Thread Mark Brown
On Tue, Aug 27, 2019 at 08:45:33AM +, Jisheng Zhang wrote: This looks mostly good and I'll apply it, a couple of small things though: > @@ -0,0 +1,192 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * SY8824C regulator driver > + * Please send a patch which updates the entire comment

[PATCH 2/8] regulator: add support for SY8824C regulator

2019-08-27 Thread Jisheng Zhang
SY8824C is an I2C attached single output regulator made by Silergy Corp, which is used on several Synaptics berlin platforms to control the power supply of the ARM cores. Add a driver for it. Signed-off-by: Jisheng Zhang --- drivers/regulator/Kconfig | 7 ++ drivers/regulator/Makefile |