Re: [PATCH 2/8] rhashtable: remove nulls_base and related code.

2018-05-07 Thread NeilBrown
On Mon, May 07 2018, Herbert Xu wrote: > On Sun, May 06, 2018 at 07:37:49AM +1000, NeilBrown wrote: >> >> I can see no evidence that this is required for anything, as it isn't >> use and I'm fairly sure that in it's current form - it cannot be used. > > Search for nulls in net/ipv4. This is defi

Re: [PATCH 2/8] rhashtable: remove nulls_base and related code.

2018-05-07 Thread Herbert Xu
On Sun, May 06, 2018 at 07:37:49AM +1000, NeilBrown wrote: > > I can see no evidence that this is required for anything, as it isn't > use and I'm fairly sure that in it's current form - it cannot be used. Search for nulls in net/ipv4. This is definitely used throughout the network stack. As th

Re: [PATCH 2/8] rhashtable: remove nulls_base and related code.

2018-05-05 Thread NeilBrown
On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> This "feature" is unused, undocumented, and untested and so >> doesn't really belong. If a use for the nulls marker >> is found, all this code would need to be reviewed to >> ensure it works as

Re: [PATCH 2/8] rhashtable: remove nulls_base and related code.

2018-05-05 Thread Herbert Xu
On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: > This "feature" is unused, undocumented, and untested and so > doesn't really belong. If a use for the nulls marker > is found, all this code would need to be reviewed to > ensure it works as required. It would be just as easy to > just

[PATCH 2/8] rhashtable: remove nulls_base and related code.

2018-05-03 Thread NeilBrown
This "feature" is unused, undocumented, and untested and so doesn't really belong. If a use for the nulls marker is found, all this code would need to be reviewed to ensure it works as required. It would be just as easy to just add the code if/when it is needed instead. This patch actually fixes