Re: [PATCH 2/9] crypto: qce: Add register defines

Hi Srini, Thanks for the comments. On 04/04/2014 12:23 PM, Srinivas Kandagatla wrote: > > Minor nitpicks. > > On 03/04/14 17:17, Stanimir Varbanov wrote: >> +#define REQ_SIZE17 /* bit 20-17 */ > > I would have defined macros like this with _SHIFT at the end, something > like this:

Re: [PATCH 2/9] crypto: qce: Add register defines

Minor nitpicks. On 03/04/14 17:17, Stanimir Varbanov wrote: +#define REQ_SIZE 17 /* bit 20-17 */ I would have defined macros like this with _SHIFT at the end, something like this: #define REQ_SIZE_SHIFT 17 +#define REQ_SIZE_MASK (0xf <<

Re: [PATCH 2/9] crypto: qce: Add register defines

Minor nitpicks. On 03/04/14 17:17, Stanimir Varbanov wrote: +#define REQ_SIZE 17 /* bit 20-17 */ I would have defined macros like this with _SHIFT at the end, something like this: #define REQ_SIZE_SHIFT 17 +#define REQ_SIZE_MASK (0xf

Re: [PATCH 2/9] crypto: qce: Add register defines

Hi Srini, Thanks for the comments. On 04/04/2014 12:23 PM, Srinivas Kandagatla wrote: Minor nitpicks. On 03/04/14 17:17, Stanimir Varbanov wrote: +#define REQ_SIZE17 /* bit 20-17 */ I would have defined macros like this with _SHIFT at the end, something like this:

Re: [PATCH 2/9] crypto: qce: Add register defines

On Apr 3, 2014, at 11:33 AM, Stanimir Varbanov wrote: > Hi, > > On 04/03/2014 07:24 PM, Kumar Gala wrote: >> >> On Apr 3, 2014, at 11:17 AM, Stanimir Varbanov wrote: >> >>> Here are all register addresses and bit/masks used by the driver. >>> >>> Signed-off-by: Stanimir Varbanov >>> ---

Re: [PATCH 2/9] crypto: qce: Add register defines

Hi, On 04/03/2014 07:24 PM, Kumar Gala wrote: > > On Apr 3, 2014, at 11:17 AM, Stanimir Varbanov wrote: > >> Here are all register addresses and bit/masks used by the driver. >> >> Signed-off-by: Stanimir Varbanov >> --- >> drivers/crypto/qce/regs-v5.h | 327 >>

Re: [PATCH 2/9] crypto: qce: Add register defines

On Apr 3, 2014, at 11:17 AM, Stanimir Varbanov wrote: > Here are all register addresses and bit/masks used by the driver. > > Signed-off-by: Stanimir Varbanov > --- > drivers/crypto/qce/regs-v5.h | 327 +++ > 1 file changed, 327 insertions(+) > create

[PATCH 2/9] crypto: qce: Add register defines

Here are all register addresses and bit/masks used by the driver. Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/regs-v5.h | 327 +++ 1 file changed, 327 insertions(+) create mode 100644 drivers/crypto/qce/regs-v5.h diff --git

[PATCH 2/9] crypto: qce: Add register defines

Here are all register addresses and bit/masks used by the driver. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com --- drivers/crypto/qce/regs-v5.h | 327 +++ 1 file changed, 327 insertions(+) create mode 100644 drivers/crypto/qce/regs-v5.h diff

Re: [PATCH 2/9] crypto: qce: Add register defines

On Apr 3, 2014, at 11:17 AM, Stanimir Varbanov svarba...@mm-sol.com wrote: Here are all register addresses and bit/masks used by the driver. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com --- drivers/crypto/qce/regs-v5.h | 327 +++ 1 file

Re: [PATCH 2/9] crypto: qce: Add register defines

Hi, On 04/03/2014 07:24 PM, Kumar Gala wrote: On Apr 3, 2014, at 11:17 AM, Stanimir Varbanov svarba...@mm-sol.com wrote: Here are all register addresses and bit/masks used by the driver. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com --- drivers/crypto/qce/regs-v5.h | 327

Re: [PATCH 2/9] crypto: qce: Add register defines

On Apr 3, 2014, at 11:33 AM, Stanimir Varbanov svarba...@mm-sol.com wrote: Hi, On 04/03/2014 07:24 PM, Kumar Gala wrote: On Apr 3, 2014, at 11:17 AM, Stanimir Varbanov svarba...@mm-sol.com wrote: Here are all register addresses and bit/masks used by the driver. Signed-off-by: