Re: [PATCH 2/9] thunderbolt: show key using %*s not %*pE

2019-09-09 Thread Joe Perches
On Thu, 2019-09-05 at 15:44 -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > %*pEp (without "h" or "o") is a no-op. This string could contain > arbitrary (non-NULL) characters, so we do want escaping. Use %*pE like > every other caller. [] > diff --git

Re: [PATCH 2/9] thunderbolt: show key using %*s not %*pE

2019-09-05 Thread Kees Cook
On Thu, Sep 05, 2019 at 03:44:26PM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > %*pEp (without "h" or "o") is a no-op. This string could contain > arbitrary (non-NULL) characters, so we do want escaping. Use %*pE like > every other caller. Agreed on all counts. pEp is actively

[PATCH 2/9] thunderbolt: show key using %*s not %*pE

2019-09-05 Thread J. Bruce Fields
From: "J. Bruce Fields" %*pEp (without "h" or "o") is a no-op. This string could contain arbitrary (non-NULL) characters, so we do want escaping. Use %*pE like every other caller. Signed-off-by: J. Bruce Fields --- drivers/thunderbolt/xdomain.c | 2 +- 1 file changed, 1 insertion(+), 1