Re: [PATCH 2/9] uprobes: check for single step support

2012-10-17 Thread Oleg Nesterov
On 10/17, Srikar Dronamraju wrote: > > * Rabin Vincent [2012-10-14 21:23:06]: > > > void __weak arch_uprobe_enable_step(struct arch_uprobe *arch) > > { > > - user_enable_single_step(current); > > + if (arch_has_single_step()) > > + user_enable_single_step(current); > > } > > > >

Re: [PATCH 2/9] uprobes: check for single step support

2012-10-17 Thread Srikar Dronamraju
* Rabin Vincent [2012-10-14 21:23:06]: > Check for single step support before calling user_enable_single_step(), > since user_enable_single_step() just BUG()s if support does not exist. > Needed by ARM. > > Signed-off-by: Rabin Vincent > --- > kernel/events/uprobes.c |3 ++- > 1 file

Re: [PATCH 2/9] uprobes: check for single step support

2012-10-17 Thread Srikar Dronamraju
* Rabin Vincent ra...@rab.in [2012-10-14 21:23:06]: Check for single step support before calling user_enable_single_step(), since user_enable_single_step() just BUG()s if support does not exist. Needed by ARM. Signed-off-by: Rabin Vincent ra...@rab.in --- kernel/events/uprobes.c |3

Re: [PATCH 2/9] uprobes: check for single step support

2012-10-17 Thread Oleg Nesterov
On 10/17, Srikar Dronamraju wrote: * Rabin Vincent ra...@rab.in [2012-10-14 21:23:06]: void __weak arch_uprobe_enable_step(struct arch_uprobe *arch) { - user_enable_single_step(current); + if (arch_has_single_step()) + user_enable_single_step(current); } void

[PATCH 2/9] uprobes: check for single step support

2012-10-14 Thread Rabin Vincent
Check for single step support before calling user_enable_single_step(), since user_enable_single_step() just BUG()s if support does not exist. Needed by ARM. Signed-off-by: Rabin Vincent --- kernel/events/uprobes.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 2/9] uprobes: check for single step support

2012-10-14 Thread Rabin Vincent
Check for single step support before calling user_enable_single_step(), since user_enable_single_step() just BUG()s if support does not exist. Needed by ARM. Signed-off-by: Rabin Vincent ra...@rab.in --- kernel/events/uprobes.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff