Re: [PATCH 2.6.11-rc3 06/11] ide: make disk flush functions use TASKFILE instead

2005-02-11 Thread Chuck Ebbert
On Thu, 10 Feb 2005 at 17:38:39 +0900, Tejun Heo wrote: > - (drive->capacity64 >= (1UL << 28))) > - rq->buffer[0] = WIN_FLUSH_CACHE_EXT; > + (drive->capacity64 >= (1UL << 28))) { > + task->tfRegister[IDE_COMMAND_OFFSET] = WIN_FLUSH_CACHE_EXT; Shouldn't

Re: [PATCH 2.6.11-rc3 06/11] ide: make disk flush functions use TASKFILE instead

2005-02-11 Thread Chuck Ebbert
On Thu, 10 Feb 2005 at 17:38:39 +0900, Tejun Heo wrote: - (drive-capacity64 = (1UL 28))) - rq-buffer[0] = WIN_FLUSH_CACHE_EXT; + (drive-capacity64 = (1UL 28))) { + task-tfRegister[IDE_COMMAND_OFFSET] = WIN_FLUSH_CACHE_EXT; Shouldn't that be

Re: [PATCH 2.6.11-rc3 06/11] ide: make disk flush functions use TASKFILE instead of TASK

2005-02-10 Thread Tejun Heo
06_ide_taskfile_flush.patch * idedisk_issue_flush() converted to use REQ_DRIVE_TASKFILE. This and the changes in ide_get_error_location() remove a possible race condition between ide_get_error_location() and other requests. * ide_queue_flush_cmd()

Re: [PATCH 2.6.11-rc3 06/11] ide: make disk flush functions use TASKFILE instead of TASK

2005-02-10 Thread Tejun Heo
06_ide_taskfile_flush.patch * idedisk_issue_flush() converted to use REQ_DRIVE_TASKFILE. This and the changes in ide_get_error_location() remove a possible race condition between ide_get_error_location() and other requests. * ide_queue_flush_cmd()