Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Domen Puncer
On 21/04/05 09:36 -0400, Ed L Cashin wrote: > "Bodo Eggert <[EMAIL PROTECTED]>" <[EMAIL PROTECTED]> writes: > > > Ed L Cashin <[EMAIL PROTECTED]> wrote: > > ... > >> + /sys/module/aoe/parameters/aoe_iflist instead of > > ^^^ > > > > Why does the module name need

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Randy.Dunlap
On Thu, 21 Apr 2005 11:30:06 -0400 Ed L Cashin wrote: | Greg KH <[EMAIL PROTECTED]> writes: | | > On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote: | >> "Bodo Eggert <[EMAIL PROTECTED]>" <[EMAIL PROTECTED]> writes: | >> | >> > Ed L Cashin <[EMAIL PROTECTED]> wrote: | >> > | >> >> +++

/sys/module (was Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration)

2005-04-21 Thread Ed L Cashin
Greg KH <[EMAIL PROTECTED]> writes: ... > It's not for things other than modules, it's filling a real need that > you yourself just pointed out. Namely, we need to be able to have > access to module paramaters in a consistant place, no matter if the > driver is built into the kernel or not. > >

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Greg KH
On Thu, Apr 21, 2005 at 11:30:06AM -0400, Ed L Cashin wrote: > Greg KH <[EMAIL PROTECTED]> writes: > > > On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote: > >> "Bodo Eggert <[EMAIL PROTECTED]>" <[EMAIL PROTECTED]> writes: > >> > >> > Ed L Cashin <[EMAIL PROTECTED]> wrote: > >> > > >>

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Ed L Cashin
Greg KH <[EMAIL PROTECTED]> writes: > On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote: >> "Bodo Eggert <[EMAIL PROTECTED]>" <[EMAIL PROTECTED]> writes: >> >> > Ed L Cashin <[EMAIL PROTECTED]> wrote: >> > >> >> +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Greg KH
On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote: > "Bodo Eggert <[EMAIL PROTECTED]>" <[EMAIL PROTECTED]> writes: > > > Ed L Cashin <[EMAIL PROTECTED]> wrote: > > > >> +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 > > > >> + When the aoe driver is a module,

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Ed L Cashin
"Bodo Eggert <[EMAIL PROTECTED]>" <[EMAIL PROTECTED]> writes: > Ed L Cashin <[EMAIL PROTECTED]> wrote: > >> +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 > >> + When the aoe driver is a module, use > > Is there any reason for this inconsistent behaviour? Yes, the

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Bodo Eggert <[EMAIL PROTECTED]>
Ed L Cashin <[EMAIL PROTECTED]> wrote: > +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 > + When the aoe driver is a module, use Is there any reason for this inconsistent behaviour? > + /sys/module/aoe/parameters/aoe_iflist instead of

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Bodo Eggert [EMAIL PROTECTED]
Ed L Cashin [EMAIL PROTECTED] wrote: +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 + When the aoe driver is a module, use Is there any reason for this inconsistent behaviour? + /sys/module/aoe/parameters/aoe_iflist instead of ^^^

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Ed L Cashin
Bodo Eggert [EMAIL PROTECTED] [EMAIL PROTECTED] writes: Ed L Cashin [EMAIL PROTECTED] wrote: +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 + When the aoe driver is a module, use Is there any reason for this inconsistent behaviour? Yes, the /sys/module/aoe area

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Greg KH
On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote: Bodo Eggert [EMAIL PROTECTED] [EMAIL PROTECTED] writes: Ed L Cashin [EMAIL PROTECTED] wrote: +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 + When the aoe driver is a module, use Is there any

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Ed L Cashin
Greg KH [EMAIL PROTECTED] writes: On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote: Bodo Eggert [EMAIL PROTECTED] [EMAIL PROTECTED] writes: Ed L Cashin [EMAIL PROTECTED] wrote: +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 + When the aoe

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Greg KH
On Thu, Apr 21, 2005 at 11:30:06AM -0400, Ed L Cashin wrote: Greg KH [EMAIL PROTECTED] writes: On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote: Bodo Eggert [EMAIL PROTECTED] [EMAIL PROTECTED] writes: Ed L Cashin [EMAIL PROTECTED] wrote: +++

/sys/module (was Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration)

2005-04-21 Thread Ed L Cashin
Greg KH [EMAIL PROTECTED] writes: ... It's not for things other than modules, it's filling a real need that you yourself just pointed out. Namely, we need to be able to have access to module paramaters in a consistant place, no matter if the driver is built into the kernel or not. Man, you

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Randy.Dunlap
On Thu, 21 Apr 2005 11:30:06 -0400 Ed L Cashin wrote: | Greg KH [EMAIL PROTECTED] writes: | | On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote: | Bodo Eggert [EMAIL PROTECTED] [EMAIL PROTECTED] writes: | | Ed L Cashin [EMAIL PROTECTED] wrote: | | +++

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Domen Puncer
On 21/04/05 09:36 -0400, Ed L Cashin wrote: Bodo Eggert [EMAIL PROTECTED] [EMAIL PROTECTED] writes: Ed L Cashin [EMAIL PROTECTED] wrote: ... + /sys/module/aoe/parameters/aoe_iflist instead of ^^^ Why does the module name need to be part of the

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-20 Thread Randy.Dunlap
On Wed, 20 Apr 2005 13:02:12 -0400 Ed L Cashin wrote: Just a nit/typo: | +modprobe aoe_iflist="eth1 eth3" | static char aoe_iflist[IFLISTSZ]; | +module_param_string(aoe_iflist, aoe_iflist, IFLISTSZ, 0600); | +MODULE_PARM_DESC(aoe_iflist, " aoe_iflist=\"dev1 [dev2 ...]\n"); No leading

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-20 Thread Ed L Cashin
"Randy.Dunlap" <[EMAIL PROTECTED]> writes: > On Wed, 20 Apr 2005 13:02:12 -0400 Ed L Cashin wrote: > > Just a nit/typo: > > | +modprobe aoe_iflist="eth1 eth3" > > | static char aoe_iflist[IFLISTSZ]; > | +module_param_string(aoe_iflist, aoe_iflist, IFLISTSZ, 0600); > |

[PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-20 Thread Ed L Cashin
improve allowed interfaces configuration Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff -uprN a/Documentation/aoe/aoe.txt b/Documentation/aoe/aoe.txt --- a/Documentation/aoe/aoe.txt 2005-04-20 11:40:55.0 -0400 +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 @@

[PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-20 Thread Ed L Cashin
improve allowed interfaces configuration Signed-off-by: Ed L. Cashin [EMAIL PROTECTED] diff -uprN a/Documentation/aoe/aoe.txt b/Documentation/aoe/aoe.txt --- a/Documentation/aoe/aoe.txt 2005-04-20 11:40:55.0 -0400 +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 @@

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-20 Thread Ed L Cashin
Randy.Dunlap [EMAIL PROTECTED] writes: On Wed, 20 Apr 2005 13:02:12 -0400 Ed L Cashin wrote: Just a nit/typo: | +modprobe aoe_iflist=eth1 eth3 | static char aoe_iflist[IFLISTSZ]; | +module_param_string(aoe_iflist, aoe_iflist, IFLISTSZ, 0600); | +MODULE_PARM_DESC(aoe_iflist,

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-20 Thread Randy.Dunlap
On Wed, 20 Apr 2005 13:02:12 -0400 Ed L Cashin wrote: Just a nit/typo: | +modprobe aoe_iflist=eth1 eth3 | static char aoe_iflist[IFLISTSZ]; | +module_param_string(aoe_iflist, aoe_iflist, IFLISTSZ, 0600); | +MODULE_PARM_DESC(aoe_iflist, aoe_iflist=\dev1 [dev2 ...]\n); No leading space (