Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-22 Thread Ingo Molnar
* Thomas Gleixner <[EMAIL PROTECTED]> wrote: > Hi all, > > On Thu, 2005-08-18 at 08:01 +0200, Ingo Molnar wrote: > > i have released the 2.6.13-rc6-rt9 tree, which can be downloaded from > > the usual place: > > I reworked the code for dynamically setting the priority of the > hrtimer

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-22 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > Quite contrary it makes the system more snappy and the overall test > > latencies go down. > > we can undo that flag - it's indeed only a couple of cycles worth of > optimization, which wont count for most workloads. I've applied your > patch, but

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-22 Thread George Anzinger
Thomas Gleixner wrote: On Sat, 2005-08-20 at 18:10 +0400, Oleg Nesterov wrote: posix_timer_event() first checks that the thread (SIGEV_THREAD_ID case) does not have PF_EXITING flag, then it calls send_sigqueue() which locks task list. But if the thread exits in between the kernel will oops.

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-22 Thread George Anzinger
Thomas Gleixner wrote: On Sat, 2005-08-20 at 18:10 +0400, Oleg Nesterov wrote: posix_timer_event() first checks that the thread (SIGEV_THREAD_ID case) does not have PF_EXITING flag, then it calls send_sigqueue() which locks task list. But if the thread exits in between the kernel will oops.

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-22 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: Quite contrary it makes the system more snappy and the overall test latencies go down. we can undo that flag - it's indeed only a couple of cycles worth of optimization, which wont count for most workloads. I've applied your patch, but we need

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-22 Thread Ingo Molnar
* Thomas Gleixner [EMAIL PROTECTED] wrote: Hi all, On Thu, 2005-08-18 at 08:01 +0200, Ingo Molnar wrote: i have released the 2.6.13-rc6-rt9 tree, which can be downloaded from the usual place: I reworked the code for dynamically setting the priority of the hrtimer softirq to be

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-20 Thread Oleg Nesterov
Thomas Gleixner wrote: > > On Sat, 2005-08-20 at 18:10 +0400, Oleg Nesterov wrote: > > > posix_timer_event() first checks that the thread (SIGEV_THREAD_ID > > case) does not have PF_EXITING flag, then it calls send_sigqueue() > > which locks task list. But if the thread exits in between the

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-20 Thread Thomas Gleixner
On Sat, 2005-08-20 at 18:10 +0400, Oleg Nesterov wrote: > posix_timer_event() first checks that the thread (SIGEV_THREAD_ID > case) does not have PF_EXITING flag, then it calls send_sigqueue() > which locks task list. But if the thread exits in between the kernel > will oops. >

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-20 Thread Oleg Nesterov
Thomas Gleixner wrote: > > send_sigqueue is called from posix_timer_fn() and acquires > tasklist_lock, which makes no sense to me. > > send_sigqueue()s (l)onl(e)y user is the posix_timer function > (posix_timer_fn(), calling posix_timer_event()). > > Each posix timer blocks the task from vanishing

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-20 Thread George Anzinger
Thomas Gleixner wrote: ~ 2. Drift of cyclic timers (armed by set_timer()): Due to rounding errors and the drift adjustment code, the fixed increment which is precalculated when the timer is set up and added on rearm, I see creeping deviation from the timeline. I have a patch lined up to

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-20 Thread George Anzinger
Thomas Gleixner wrote: George, On Fri, 2005-08-19 at 17:19 -0700, George Anzinger wrote: 2. Drift of cyclic timers (armed by set_timer()): Due to rounding errors and the drift adjustment code, the fixed increment which is precalculated when the timer is set up and added on rearm, I see

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-20 Thread George Anzinger
Thomas Gleixner wrote: ~ 2. Drift of cyclic timers (armed by set_timer()): Due to rounding errors and the drift adjustment code, the fixed increment which is precalculated when the timer is set up and added on rearm, I see creeping deviation from the timeline. I have a patch lined up to

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-20 Thread George Anzinger
Thomas Gleixner wrote: George, On Fri, 2005-08-19 at 17:19 -0700, George Anzinger wrote: 2. Drift of cyclic timers (armed by set_timer()): Due to rounding errors and the drift adjustment code, the fixed increment which is precalculated when the timer is set up and added on rearm, I see

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-20 Thread Oleg Nesterov
Thomas Gleixner wrote: send_sigqueue is called from posix_timer_fn() and acquires tasklist_lock, which makes no sense to me. send_sigqueue()s (l)onl(e)y user is the posix_timer function (posix_timer_fn(), calling posix_timer_event()). Each posix timer blocks the task from vanishing away by

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-20 Thread Thomas Gleixner
On Sat, 2005-08-20 at 18:10 +0400, Oleg Nesterov wrote: posix_timer_event() first checks that the thread (SIGEV_THREAD_ID case) does not have PF_EXITING flag, then it calls send_sigqueue() which locks task list. But if the thread exits in between the kernel will oops. posix_timer_event()

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-20 Thread Oleg Nesterov
Thomas Gleixner wrote: On Sat, 2005-08-20 at 18:10 +0400, Oleg Nesterov wrote: posix_timer_event() first checks that the thread (SIGEV_THREAD_ID case) does not have PF_EXITING flag, then it calls send_sigqueue() which locks task list. But if the thread exits in between the kernel will

Re: [PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-19 Thread Thomas Gleixner
George, On Fri, 2005-08-19 at 17:19 -0700, George Anzinger wrote: > > 2. Drift of cyclic timers (armed by set_timer()): > > > > Due to rounding errors and the drift adjustment code, the fixed > > increment which is precalculated when the timer is set up and added on > > rearm, I see creeping

[PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-19 Thread Thomas Gleixner
Hi all, On Thu, 2005-08-18 at 08:01 +0200, Ingo Molnar wrote: > i have released the 2.6.13-rc6-rt9 tree, which can be downloaded from > the usual place: I reworked the code for dynamically setting the priority of the hrtimer softirq to be aware of PI. The current function "mutex_chprio()" in

[PATCH 2.6.13-rc6-rt9] PI aware dynamic priority adjustment

2005-08-19 Thread Thomas Gleixner
Hi all, On Thu, 2005-08-18 at 08:01 +0200, Ingo Molnar wrote: i have released the 2.6.13-rc6-rt9 tree, which can be downloaded from the usual place: I reworked the code for dynamically setting the priority of the hrtimer softirq to be aware of PI. The current function mutex_chprio() in -rt9