Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-19 Thread Benjamin Herrenschmidt
> If I make the root device a basic struct device, it can't be part of > ibmebus any > longer. If we could create a busless device, we wouldn't have a problem, > but I > doubt that is possible. > > Do you have any creative ideas? Well, I think PCI does just that for PCI busses ... (a busless

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-19 Thread Joachim Fenkes
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote on 17.02.2007 19:37:25: > > > Doh ! You are creating an of_device with no attached device-node ? That > > > is totally evil ! Why do you need that ? > > > > The driver creates a fake "ibmebus" device so all ibmebus based devices > > have > > a

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-19 Thread Joachim Fenkes
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote on 17.02.2007 19:37:25: Doh ! You are creating an of_device with no attached device-node ? That is totally evil ! Why do you need that ? The driver creates a fake ibmebus device so all ibmebus based devices have a common parent

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-19 Thread Benjamin Herrenschmidt
If I make the root device a basic struct device, it can't be part of ibmebus any longer. If we could create a busless device, we wouldn't have a problem, but I doubt that is possible. Do you have any creative ideas? Well, I think PCI does just that for PCI busses ... (a busless device)

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Benjamin Herrenschmidt
On Sat, 2007-02-17 at 19:21 -0500, Joachim Fenkes wrote: > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote on 17.02.2007 > 16:56:39: > > > On Sat, 2007-02-17 at 17:28 +0100, Hoang-Nam Nguyen wrote: > > > ibmebus has a fake root device that's not associated with an ofdt > node. > > > Filter out

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Joachim Fenkes
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote on 17.02.2007 16:56:39: > On Sat, 2007-02-17 at 17:28 +0100, Hoang-Nam Nguyen wrote: > > ibmebus has a fake root device that's not associated with an ofdt node. > > Filter out any such devices in of_device_uevent(). > > Doh ! You are creating an

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Benjamin Herrenschmidt
On Sat, 2007-02-17 at 17:28 +0100, Hoang-Nam Nguyen wrote: > ibmebus has a fake root device that's not associated with an ofdt node. > Filter out any such devices in of_device_uevent(). Doh ! You are creating an of_device with no attached device-node ? That is totally evil ! Why do you need that

[PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Hoang-Nam Nguyen
ibmebus has a fake root device that's not associated with an ofdt node. Filter out any such devices in of_device_uevent(). Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- of_device.c |4 1 files changed, 4 insertions(+) diff -urp a/arch/powerpc/kernel/of_device.c

[PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Hoang-Nam Nguyen
ibmebus has a fake root device that's not associated with an ofdt node. Filter out any such devices in of_device_uevent(). Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- of_device.c |4 1 files changed, 4 insertions(+) diff -urp a/arch/powerpc/kernel/of_device.c

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Benjamin Herrenschmidt
On Sat, 2007-02-17 at 17:28 +0100, Hoang-Nam Nguyen wrote: ibmebus has a fake root device that's not associated with an ofdt node. Filter out any such devices in of_device_uevent(). Doh ! You are creating an of_device with no attached device-node ? That is totally evil ! Why do you need that ?

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Joachim Fenkes
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote on 17.02.2007 16:56:39: On Sat, 2007-02-17 at 17:28 +0100, Hoang-Nam Nguyen wrote: ibmebus has a fake root device that's not associated with an ofdt node. Filter out any such devices in of_device_uevent(). Doh ! You are creating an

Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Benjamin Herrenschmidt
On Sat, 2007-02-17 at 19:21 -0500, Joachim Fenkes wrote: Benjamin Herrenschmidt [EMAIL PROTECTED] wrote on 17.02.2007 16:56:39: On Sat, 2007-02-17 at 17:28 +0100, Hoang-Nam Nguyen wrote: ibmebus has a fake root device that's not associated with an ofdt node. Filter out any such