Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU kernels

2007-02-12 Thread Siddha, Suresh B
On Mon, Feb 12, 2007 at 04:10:44PM -0700, Eric W. Biederman wrote: > Basically as I commented in genapic_flat, that at least on hyperthreading > cpus the destination mask is not always honored, and so if you only > allow one hyperthread I have seen the irq show up on the other hyperthread. Which p

Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU kernels

2007-02-12 Thread Siddha, Suresh B
On Mon, Feb 12, 2007 at 11:36:23PM +0100, Andi Kleen wrote: > True, that seems to be missing. > > I agree that the patch seems to consist mostly of renaming doesn't make > it any easier to read. > > And it's worrying that it doesn't handle the hotplug case at all. This patch is mostly a cleanup

Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU kernels

2007-02-12 Thread Eric W. Biederman
Andi Kleen <[EMAIL PROTECTED]> writes: > What experimental evidence did you have? > > But I'm tempted to drop this unless the hotplug mystery can be cleared > up. There was past information that logical is unsafe for hotplug. Basically as I commented in genapic_flat, that at least on hyperthrea

Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU kernels

2007-02-12 Thread Andi Kleen
On Sunday 11 February 2007 12:13, Eric W. Biederman wrote: > Andi Kleen <[EMAIL PROTECTED]> writes: > > > From: Ingo Molnar <[EMAIL PROTECTED]> > > > > Default to physical mode on hotplug CPU kernels. Furher simplify and clean > > up > > the APIC initialization code. > > Where is the code that

Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU kernels

2007-02-11 Thread Eric W. Biederman
Andi Kleen <[EMAIL PROTECTED]> writes: > From: Ingo Molnar <[EMAIL PROTECTED]> > > Default to physical mode on hotplug CPU kernels. Furher simplify and clean up > the APIC initialization code. Where is the code that the subject describes? I have two problems here. - I don't see anything handli

[PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU kernels

2007-02-10 Thread Andi Kleen
From: Ingo Molnar <[EMAIL PROTECTED]> Default to physical mode on hotplug CPU kernels. Furher simplify and clean up the APIC initialization code. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Cc: Suresh Siddha <[EMAIL PROTECTED]> Cc: Andi Kleen <[E