Re: [PATCH 20/21] ide-floppy: merge idefloppy_{input,output}_buffers

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by > introducing a 4th arg. called direction. According to its value > we atapi_input_bytes() or atapi_output_bytes(). Also, simplify the interrupt This change is fine but ..

[PATCH 20/21] ide-floppy: merge idefloppy_{input,output}_buffers

2008-01-11 Thread Borislav Petkov
We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by introducing a 4th arg. called direction. According to its value we atapi_input_bytes() or atapi_output_bytes(). Also, simplify the interrupt handler by removing multiple calls testing the data direction and using a local var