Re: [PATCH 20/30] KVM: SVM: preserve VGIF across VMCB switch

2020-06-01 Thread Paolo Bonzini
On 01/06/20 01:11, Krish Sadhukhan wrote: >> >> +    svm->vmcb->control.int_ctl = >> +    (svm->nested.ctl.int_ctl & ~mask) | >> +    (svm->nested.hsave->control.int_ctl & mask); > > > If this is the very first VMRUN, do we have any int_ctl saved in hsave ? Yes,

Re: [PATCH 20/30] KVM: SVM: preserve VGIF across VMCB switch

2020-05-31 Thread Krish Sadhukhan
On 5/29/20 8:39 AM, Paolo Bonzini wrote: There is only one GIF flag for the whole processor, so make sure it is not clobbered when switching to L2 (in which case we also have to include the V_GIF_ENABLE_MASK, lest we confuse enable_gif/disable_gif/gif_set). When going back, L1 could in

[PATCH 20/30] KVM: SVM: preserve VGIF across VMCB switch

2020-05-29 Thread Paolo Bonzini
There is only one GIF flag for the whole processor, so make sure it is not clobbered when switching to L2 (in which case we also have to include the V_GIF_ENABLE_MASK, lest we confuse enable_gif/disable_gif/gif_set). When going back, L1 could in theory have entered L2 without issuing a CLGI so