Re: [PATCH 20/34] x86, pkeys: differentiate instruction fetches

2015-12-08 Thread Thomas Gleixner
On Thu, 3 Dec 2015, Dave Hansen wrote: > static inline bool arch_vma_access_permitted(struct vm_area_struct *vma, > - bool write, bool foreign) > + bool write, bool execute, bool foreign) > + /* > + * gups are always data accesses, not instruction > + *

Re: [PATCH 20/34] x86, pkeys: differentiate instruction fetches

2015-12-08 Thread Thomas Gleixner
On Thu, 3 Dec 2015, Dave Hansen wrote: > static inline bool arch_vma_access_permitted(struct vm_area_struct *vma, > - bool write, bool foreign) > + bool write, bool execute, bool foreign) > + /* > + * gups are always data accesses, not instruction > + *

[PATCH 20/34] x86, pkeys: differentiate instruction fetches

2015-12-03 Thread Dave Hansen
From: Dave Hansen As discussed earlier, we attempt to enforce protection keys in software. However, the code checks all faults to ensure that they are not violating protection key permissions. It was assumed that all faults are either write faults where we check PKRU[key].WD (write disable)

[PATCH 20/34] x86, pkeys: differentiate instruction fetches

2015-12-03 Thread Dave Hansen
From: Dave Hansen As discussed earlier, we attempt to enforce protection keys in software. However, the code checks all faults to ensure that they are not violating protection key permissions. It was assumed that all faults are either write faults where we check