Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

Hi, > > + mmiowb(); > > +} > > What is the barrier for? Same question for all the other instances No idea. Removed them all, seems to work fine still. Guess writel() & friends have the needed barriers on arm? > > + > > +static void bcm2835_sdhost_reset(struct mmc_host *mmc) > > +{ > > +

Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

Hi, > > + mmiowb(); > > +} > > What is the barrier for? Same question for all the other instances No idea. Removed them all, seems to work fine still. Guess writel() & friends have the needed barriers on arm? > > + > > +static void bcm2835_sdhost_reset(struct mmc_host *mmc) > > +{ > > +

Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

On Thursday, June 2, 2016 11:12:38 AM CEST Eric Anholt wrote: > Arnd Bergmann writes: > > > On Wednesday, June 1, 2016 11:43:30 PM CEST Gerd Hoffmann wrote: > >> +/* Parse OF address directly to get the physical address for > >> + * DMA to our registers. > >> + */ > >>

Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

On Thursday, June 2, 2016 11:12:38 AM CEST Eric Anholt wrote: > Arnd Bergmann writes: > > > On Wednesday, June 1, 2016 11:43:30 PM CEST Gerd Hoffmann wrote: > >> +/* Parse OF address directly to get the physical address for > >> + * DMA to our registers. > >> + */ > >> +

Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

Arnd Bergmann writes: > On Wednesday, June 1, 2016 11:43:30 PM CEST Gerd Hoffmann wrote: >> +/* Parse OF address directly to get the physical address for >> + * DMA to our registers. >> + */ >> +host->phys_addr = be32_to_cpup(of_get_address(pdev->dev.of_node, 0, >>

Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

Arnd Bergmann writes: > On Wednesday, June 1, 2016 11:43:30 PM CEST Gerd Hoffmann wrote: >> +/* Parse OF address directly to get the physical address for >> + * DMA to our registers. >> + */ >> +host->phys_addr = be32_to_cpup(of_get_address(pdev->dev.of_node, 0, >> +

Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

On Wednesday, June 1, 2016 11:43:30 PM CEST Gerd Hoffmann wrote: > +static void bcm2835_sdhost_reset_internal(struct bcm2835_host *host) > +{ > + u32 temp; > + > + bcm2835_sdhost_set_power(host, false); > + > + bcm2835_sdhost_write(host, 0, SDCMD); > + bcm2835_sdhost_write(host,

Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

On Wednesday, June 1, 2016 11:43:30 PM CEST Gerd Hoffmann wrote: > +static void bcm2835_sdhost_reset_internal(struct bcm2835_host *host) > +{ > + u32 temp; > + > + bcm2835_sdhost_set_power(host, false); > + > + bcm2835_sdhost_write(host, 0, SDCMD); > + bcm2835_sdhost_write(host,

[PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

From: Eric Anholt The 2835 has two SD controllers: The Arasan SDHCI controller that we currently use, and a custom SD controller. The custom one runs faster The code was originally written by Phil Elwell in the downstream Rasbperry Pi tree, and I did a major cleanup on it

[PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

From: Eric Anholt The 2835 has two SD controllers: The Arasan SDHCI controller that we currently use, and a custom SD controller. The custom one runs faster The code was originally written by Phil Elwell in the downstream Rasbperry Pi tree, and I did a major cleanup on it (+319, -707 lines out