Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Peter Zijlstra
On Tue, 2008-02-26 at 13:45 +0100, Miklos Szeredi wrote: > Starting review in the middle, because this is the part I'm most > familiar with. > > > New addres_space_operations methods are added: > > int swapfile(struct address_space *, int); > > Separate ->swapon() and ->swapoff() methods

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Miklos Szeredi
Starting review in the middle, because this is the part I'm most familiar with. > New addres_space_operations methods are added: > int swapfile(struct address_space *, int); Separate ->swapon() and ->swapoff() methods would be so much cleaner IMO. Also is there a reason why 'struct file *'

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Miklos Szeredi
Starting review in the middle, because this is the part I'm most familiar with. New addres_space_operations methods are added: int swapfile(struct address_space *, int); Separate -swapon() and -swapoff() methods would be so much cleaner IMO. Also is there a reason why 'struct file *' cannot

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Peter Zijlstra
On Tue, 2008-02-26 at 13:45 +0100, Miklos Szeredi wrote: Starting review in the middle, because this is the part I'm most familiar with. New addres_space_operations methods are added: int swapfile(struct address_space *, int); Separate -swapon() and -swapoff() methods would be so

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Peter Zijlstra
On Wed, 2008-02-20 at 08:30 -0800, Randy Dunlap wrote: > On Wed, 20 Feb 2008 15:46:32 +0100 Peter Zijlstra wrote: < grammar mistakes > Thanks Randy! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Randy Dunlap
On Wed, 20 Feb 2008 15:46:32 +0100 Peter Zijlstra wrote: > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > --- > Documentation/filesystems/Locking | 19 + > Documentation/filesystems/vfs.txt | 17 > include/linux/buffer_head.h |2 - > include/linux/fs.h

[PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Peter Zijlstra
New addres_space_operations methods are added: int swapfile(struct address_space *, int); int swap_out(struct file *, struct page *, struct writeback_control *); int swap_in(struct file *, struct page *); When during sys_swapon() the swapfile() method is found and returns no error the

[PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Peter Zijlstra
New addres_space_operations methods are added: int swapfile(struct address_space *, int); int swap_out(struct file *, struct page *, struct writeback_control *); int swap_in(struct file *, struct page *); When during sys_swapon() the swapfile() method is found and returns no error the

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Peter Zijlstra
On Wed, 2008-02-20 at 08:30 -0800, Randy Dunlap wrote: On Wed, 20 Feb 2008 15:46:32 +0100 Peter Zijlstra wrote: grammar mistakes Thanks Randy! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Randy Dunlap
On Wed, 20 Feb 2008 15:46:32 +0100 Peter Zijlstra wrote: Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- Documentation/filesystems/Locking | 19 + Documentation/filesystems/vfs.txt | 17 include/linux/buffer_head.h |2 - include/linux/fs.h