Re: [PATCH 24/35] mfd: ab8500: Remove unnecessary 'struct device' declaration

2013-02-25 Thread Arnd Bergmann
On Monday 25 February 2013, Lee Jones wrote: > > and others that use 'struct device'. C99 requires that a struct is declared > > in advance before you use it in a function declaration. > > Hmm... I wonder why it doesn't complain then? > > I'll remove the patch. It's only a problem if the file i

Re: [PATCH 24/35] mfd: ab8500: Remove unnecessary 'struct device' declaration

2013-02-25 Thread Lee Jones
On Mon, 25 Feb 2013, Arnd Bergmann wrote: > On Friday 15 February 2013, Lee Jones wrote: > > A recent patch saw the device.h include being removed from some other > > include files and replaced with a 'struct device' declaration instead. > > However, neither the include nor the declaration is actu

Re: [PATCH 24/35] mfd: ab8500: Remove unnecessary 'struct device' declaration

2013-02-25 Thread Arnd Bergmann
On Friday 15 February 2013, Lee Jones wrote: > A recent patch saw the device.h include being removed from some other > include files and replaced with a 'struct device' declaration instead. > However, neither the include nor the declaration is actually required. > > Signed-off-by: Lee Jones > ---

[PATCH 24/35] mfd: ab8500: Remove unnecessary 'struct device' declaration

2013-02-15 Thread Lee Jones
A recent patch saw the device.h include being removed from some other include files and replaced with a 'struct device' declaration instead. However, neither the include nor the declaration is actually required. Signed-off-by: Lee Jones --- include/linux/mfd/abx500.h |2 -- 1 file changed, 2