Re: [alsa-devel] [PATCH 3/3] ASoC: cros_ec_codec: Add codec driver for Cros EC

2018-12-24 Thread Cheng-yi Chiang
On Thu, Nov 29, 2018 at 8:42 PM Enric Balletbo Serra wrote: > > Hi Cheng-Yi > > Many thanks for the patch. I am not really an ASoC expert, so my > comments are more based on the feedback for other cros-ec drivers. So, > various nits and few comments below. > Hi Enric, Thank you for the review a

Re: [alsa-devel] [PATCH 3/3] ASoC: cros_ec_codec: Add codec driver for Cros EC

2018-11-29 Thread Enric Balletbo Serra
Hi Cheng-Yi Many thanks for the patch. I am not really an ASoC expert, so my comments are more based on the feedback for other cros-ec drivers. So, various nits and few comments below. The first question I'd like to ask is if there is any EC_FEATURE that tells you that the cros-ec has the codec.

[PATCH 3/3] ASoC: cros_ec_codec: Add codec driver for Cros EC

2018-11-27 Thread Cheng-Yi Chiang
Add a codec driver to control ChromeOS EC codec. Use EC Host command to enable/disable I2S recording and control other configurations. Signed-off-by: Cheng-Yi Chiang --- MAINTAINERS | 1 + sound/soc/codecs/Kconfig | 8 + sound/soc/codecs/Makefile| 2 +