Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-10 Thread Simon Jeons
On Wed, 2012-12-05 at 16:47 -0500, Naoya Horiguchi wrote: > Memory error handling on hugepages can break a RSS counter, which emits > a message like "Bad rss-counter state mm:88040abecac0 idx:1 val:-1". > This is because PageAnon returns true for hugepage (this behavior is Could you explain

Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-10 Thread Simon Jeons
On Wed, 2012-12-05 at 16:47 -0500, Naoya Horiguchi wrote: Memory error handling on hugepages can break a RSS counter, which emits a message like Bad rss-counter state mm:88040abecac0 idx:1 val:-1. This is because PageAnon returns true for hugepage (this behavior is Could you explain why

Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-06 Thread Andrew Morton
On Thu, 6 Dec 2012 20:22:42 -0500 Naoya Horiguchi wrote: > > --- a/mm/rmap.c~hwpoison-hugetlbfs-fix-rss-counter-warning-fix > > +++ a/mm/rmap.c > > @@ -1249,14 +1249,14 @@ int try_to_unmap_one(struct page *page, > > update_hiwater_rss(mm); > > > > if (PageHWPoison(page) && !(flags &

Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-06 Thread Naoya Horiguchi
On Thu, Dec 06, 2012 at 02:40:08PM -0800, Andrew Morton wrote: ... > > On Wed, Dec 05, 2012 at 10:04:50PM +, Luck, Tony wrote: > > > if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) { > > > - if (PageAnon(page)) > > > + if (PageHuge(page)) > > > + ; >

Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-06 Thread Andrew Morton
On Wed, 5 Dec 2012 17:14:33 -0500 Naoya Horiguchi wrote: > Hi Tony, > > On Wed, Dec 05, 2012 at 10:04:50PM +, Luck, Tony wrote: > > if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) { > > - if (PageAnon(page)) > > + if (PageHuge(page)) > > +

Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-06 Thread Andrew Morton
On Wed, 5 Dec 2012 17:14:33 -0500 Naoya Horiguchi n-horigu...@ah.jp.nec.com wrote: Hi Tony, On Wed, Dec 05, 2012 at 10:04:50PM +, Luck, Tony wrote: if (PageHWPoison(page) !(flags TTU_IGNORE_HWPOISON)) { - if (PageAnon(page)) + if (PageHuge(page)) +

Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-06 Thread Naoya Horiguchi
On Thu, Dec 06, 2012 at 02:40:08PM -0800, Andrew Morton wrote: ... On Wed, Dec 05, 2012 at 10:04:50PM +, Luck, Tony wrote: if (PageHWPoison(page) !(flags TTU_IGNORE_HWPOISON)) { - if (PageAnon(page)) + if (PageHuge(page)) + ; + else

Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-06 Thread Andrew Morton
On Thu, 6 Dec 2012 20:22:42 -0500 Naoya Horiguchi n-horigu...@ah.jp.nec.com wrote: --- a/mm/rmap.c~hwpoison-hugetlbfs-fix-rss-counter-warning-fix +++ a/mm/rmap.c @@ -1249,14 +1249,14 @@ int try_to_unmap_one(struct page *page, update_hiwater_rss(mm); if (PageHWPoison(page)

Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-05 Thread Naoya Horiguchi
Hi Tony, On Wed, Dec 05, 2012 at 10:04:50PM +, Luck, Tony wrote: > if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) { > - if (PageAnon(page)) > + if (PageHuge(page)) > + ; > + else if (PageAnon(page)) >

RE: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-05 Thread Luck, Tony
if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) { - if (PageAnon(page)) + if (PageHuge(page)) + ; + else if (PageAnon(page)) dec_mm_counter(mm, MM_ANONPAGES); else

[PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-05 Thread Naoya Horiguchi
Memory error handling on hugepages can break a RSS counter, which emits a message like "Bad rss-counter state mm:88040abecac0 idx:1 val:-1". This is because PageAnon returns true for hugepage (this behavior is necessary for reverse mapping to work on hugetlbfs). Signed-off-by: Naoya Horiguchi

[PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-05 Thread Naoya Horiguchi
Memory error handling on hugepages can break a RSS counter, which emits a message like Bad rss-counter state mm:88040abecac0 idx:1 val:-1. This is because PageAnon returns true for hugepage (this behavior is necessary for reverse mapping to work on hugetlbfs). Signed-off-by: Naoya Horiguchi

RE: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-05 Thread Luck, Tony
if (PageHWPoison(page) !(flags TTU_IGNORE_HWPOISON)) { - if (PageAnon(page)) + if (PageHuge(page)) + ; + else if (PageAnon(page)) dec_mm_counter(mm, MM_ANONPAGES); else

Re: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning

2012-12-05 Thread Naoya Horiguchi
Hi Tony, On Wed, Dec 05, 2012 at 10:04:50PM +, Luck, Tony wrote: if (PageHWPoison(page) !(flags TTU_IGNORE_HWPOISON)) { - if (PageAnon(page)) + if (PageHuge(page)) + ; + else if (PageAnon(page))