Re: [PATCH 3/3] clk: keystone: Fix missing iounmap calls in an error handling path

2016-10-25 Thread Stephen Boyd
On 10/25, walter harms wrote: > Am 24.10.2016 22:43, schrieb Christophe JAILLET: > > @@ -220,6 +218,12 @@ static void __init _of_pll_clk_init(struct device_node > > *node, bool pllctrl) > > > > out: > > pr_err("%s: error initializing pll %s\n", __func__, node->name); > > + if

Re: [PATCH 3/3] clk: keystone: Fix missing iounmap calls in an error handling path

2016-10-25 Thread Stephen Boyd
On 10/25, walter harms wrote: > Am 24.10.2016 22:43, schrieb Christophe JAILLET: > > @@ -220,6 +218,12 @@ static void __init _of_pll_clk_init(struct device_node > > *node, bool pllctrl) > > > > out: > > pr_err("%s: error initializing pll %s\n", __func__, node->name); > > + if

Re: [PATCH 3/3] clk: keystone: Fix missing iounmap calls in an error handling path

2016-10-25 Thread walter harms
Am 24.10.2016 22:43, schrieb Christophe JAILLET: > Factorize 'iounmap()' calls in the error handling path. > The main goal is to add these calls if 'clk_register_pll()' fails. > > Add an error message if an 'of_iomap' call fails to be consistent. > > Signed-off-by: Christophe JAILLET

Re: [PATCH 3/3] clk: keystone: Fix missing iounmap calls in an error handling path

2016-10-25 Thread walter harms
Am 24.10.2016 22:43, schrieb Christophe JAILLET: > Factorize 'iounmap()' calls in the error handling path. > The main goal is to add these calls if 'clk_register_pll()' fails. > > Add an error message if an 'of_iomap' call fails to be consistent. > > Signed-off-by: Christophe JAILLET > --- >

[PATCH 3/3] clk: keystone: Fix missing iounmap calls in an error handling path

2016-10-24 Thread Christophe JAILLET
Factorize 'iounmap()' calls in the error handling path. The main goal is to add these calls if 'clk_register_pll()' fails. Add an error message if an 'of_iomap' call fails to be consistent. Signed-off-by: Christophe JAILLET --- Un-compiled & un-tested ---

[PATCH 3/3] clk: keystone: Fix missing iounmap calls in an error handling path

2016-10-24 Thread Christophe JAILLET
Factorize 'iounmap()' calls in the error handling path. The main goal is to add these calls if 'clk_register_pll()' fails. Add an error message if an 'of_iomap' call fails to be consistent. Signed-off-by: Christophe JAILLET --- Un-compiled & un-tested --- drivers/clk/keystone/pll.c | 10