Re: [PATCH 3/3] comedi: driver: Fix - BIT macro used coding style issue

2015-11-06 Thread Dan Carpenter
On Thu, Nov 05, 2015 at 09:27:45PM +0530, Ranjith wrote: > BIT macro is used for defining bit location instead of shifting > operator - coding style issue > > Signed-off-by: Ranjith T You're From line and your signed-off line need to match and they both need to be your legal name that you use

Re: [PATCH 3/3] comedi: driver: Fix - BIT macro used coding style issue

2015-11-06 Thread Greg KH
On Fri, Nov 06, 2015 at 07:24:18PM +0530, Ranjith T wrote: > Is this patch is fine?..Because I didn't get any reply for this patch You sent it 1 day ago, while we are in the middle of the merge window and I can't touch anything for 2 weeks at the earliest. Please be patient. greg k-h -- To

Re: [PATCH 3/3] comedi: driver: Fix - BIT macro used coding style issue

2015-11-06 Thread Ian Abbott
On 06/11/15 13:54, Ranjith T wrote: Is this patch is fine?..Because I didn't get any reply for this patch Your patch numbering sucks. Isolated patches should just use [PATCH], not [PATCH 3/3], [PATCH 4/4], etc. Also, could you mention the name of the COMEDI driver in the patch title,

Re: [PATCH 3/3] comedi: driver: Fix - BIT macro used coding style issue

2015-11-06 Thread Ranjith T
Is this patch is fine?..Because I didn't get any reply for this patch Thanks, Ranjith.T. On Thu, Nov 5, 2015 at 9:27 PM, Ranjith wrote: > BIT macro is used for defining bit location instead of shifting > operator - coding style issue > > Signed-off-by: Ranjith T > --- >

Re: [PATCH 3/3] comedi: driver: Fix - BIT macro used coding style issue

2015-11-06 Thread Ian Abbott
On 06/11/15 13:54, Ranjith T wrote: Is this patch is fine?..Because I didn't get any reply for this patch Your patch numbering sucks. Isolated patches should just use [PATCH], not [PATCH 3/3], [PATCH 4/4], etc. Also, could you mention the name of the COMEDI driver in the patch title,

Re: [PATCH 3/3] comedi: driver: Fix - BIT macro used coding style issue

2015-11-06 Thread Greg KH
On Fri, Nov 06, 2015 at 07:24:18PM +0530, Ranjith T wrote: > Is this patch is fine?..Because I didn't get any reply for this patch You sent it 1 day ago, while we are in the middle of the merge window and I can't touch anything for 2 weeks at the earliest. Please be patient. greg k-h -- To

Re: [PATCH 3/3] comedi: driver: Fix - BIT macro used coding style issue

2015-11-06 Thread Dan Carpenter
On Thu, Nov 05, 2015 at 09:27:45PM +0530, Ranjith wrote: > BIT macro is used for defining bit location instead of shifting > operator - coding style issue > > Signed-off-by: Ranjith T You're From line and your signed-off line need to match and they both need to be your

Re: [PATCH 3/3] comedi: driver: Fix - BIT macro used coding style issue

2015-11-06 Thread Ranjith T
Is this patch is fine?..Because I didn't get any reply for this patch Thanks, Ranjith.T. On Thu, Nov 5, 2015 at 9:27 PM, Ranjith wrote: > BIT macro is used for defining bit location instead of shifting > operator - coding style issue > > Signed-off-by: Ranjith T

[PATCH 3/3] comedi: driver: Fix - BIT macro used coding style issue

2015-11-05 Thread Ranjith
BIT macro is used for defining bit location instead of shifting operator - coding style issue Signed-off-by: Ranjith T --- drivers/staging/comedi/drivers/pcmmio.c | 42 +++ 1 file changed, 21 insertions(+), 21 deletions(-) diff --git

[PATCH 3/3] comedi: driver: Fix - BIT macro used coding style issue

2015-11-05 Thread Ranjith
BIT macro is used for defining bit location instead of shifting operator - coding style issue Signed-off-by: Ranjith T --- drivers/staging/comedi/drivers/pcmmio.c | 42 +++ 1 file changed, 21 insertions(+), 21 deletions(-) diff --git