RE: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-09-11 Thread Radhey Shyam Pandey
> > > > Yeah that part was clear but the implementation can be better.. > > I thought over it and it seems having a new interface dma_ctrl_write_64 > > taking lsb and msb bits input looks better and scalable. It will be similar > > to existing vdma_desc_write_64 impl. I will send v2 if it looks

RE: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-09-11 Thread Radhey Shyam Pandey
> > > > Yeah that part was clear but the implementation can be better.. > > I thought over it and it seems having a new interface dma_ctrl_write_64 > > taking lsb and msb bits input looks better and scalable. It will be similar > > to existing vdma_desc_write_64 impl. I will send v2 if it looks

Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-09-11 Thread Vinod
On 07-09-18, 12:08, Radhey Shyam Pandey wrote: > > > Yeah that part was clear but the implementation can be better.. > I thought over it and it seems having a new interface dma_ctrl_write_64 > taking lsb and msb bits input looks better and scalable. It will be similar > to existing

Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-09-11 Thread Vinod
On 07-09-18, 12:08, Radhey Shyam Pandey wrote: > > > Yeah that part was clear but the implementation can be better.. > I thought over it and it seems having a new interface dma_ctrl_write_64 > taking lsb and msb bits input looks better and scalable. It will be similar > to existing

RE: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-09-07 Thread Radhey Shyam Pandey
> > > > > - xilinx_write(chan, XILINX_CDMA_REG_SRCADDR, hw- > > > > >src_addr); > > > > > - xilinx_write(chan, XILINX_CDMA_REG_DSTADDR, hw- > > > > >dest_addr); > > > > > + xilinx_write(chan, XILINX_CDMA_REG_SRCADDR, > > > > (dma_addr_t) > > > > > +

RE: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-09-07 Thread Radhey Shyam Pandey
> > > > > - xilinx_write(chan, XILINX_CDMA_REG_SRCADDR, hw- > > > > >src_addr); > > > > > - xilinx_write(chan, XILINX_CDMA_REG_DSTADDR, hw- > > > > >dest_addr); > > > > > + xilinx_write(chan, XILINX_CDMA_REG_SRCADDR, > > > > (dma_addr_t) > > > > > +

RE: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-08-29 Thread Radhey Shyam Pandey
ead.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA > transfer > > On 28-08-18, 14:03, Radhey Shyam Pandey wrote: > > > On 27-07-18, 16:20, Radhey Shyam Pandey wrote: > > > > In AXI CDMA simple mode als

RE: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-08-29 Thread Radhey Shyam Pandey
ead.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA > transfer > > On 28-08-18, 14:03, Radhey Shyam Pandey wrote: > > > On 27-07-18, 16:20, Radhey Shyam Pandey wrote: > > > > In AXI CDMA simple mode als

Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-08-28 Thread Vinod
On 28-08-18, 14:03, Radhey Shyam Pandey wrote: > > On 27-07-18, 16:20, Radhey Shyam Pandey wrote: > > > In AXI CDMA simple mode also pass MSB bits of source and destination > > > address to xilinx_write function. This fixes simple CDMA operation > > > mode using 64-bit addressing. > > > > > >

Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-08-28 Thread Vinod
On 28-08-18, 14:03, Radhey Shyam Pandey wrote: > > On 27-07-18, 16:20, Radhey Shyam Pandey wrote: > > > In AXI CDMA simple mode also pass MSB bits of source and destination > > > address to xilinx_write function. This fixes simple CDMA operation > > > mode using 64-bit addressing. > > > > > >

RE: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-08-28 Thread Radhey Shyam Pandey
ead.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA > transfer > > On 27-07-18, 16:20, Radhey Shyam Pandey wrote: > > In AXI CDMA simple mode also pass MSB bits of source and destination > > address to xilinx_write fun

RE: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-08-28 Thread Radhey Shyam Pandey
ead.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA > transfer > > On 27-07-18, 16:20, Radhey Shyam Pandey wrote: > > In AXI CDMA simple mode also pass MSB bits of source and destination > > address to xilinx_write fun

Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-08-21 Thread Vinod
On 27-07-18, 16:20, Radhey Shyam Pandey wrote: > In AXI CDMA simple mode also pass MSB bits of source and destination > address to xilinx_write function. This fixes simple CDMA operation > mode using 64-bit addressing. > > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Michal Simek > --- >

Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-08-21 Thread Vinod
On 27-07-18, 16:20, Radhey Shyam Pandey wrote: > In AXI CDMA simple mode also pass MSB bits of source and destination > address to xilinx_write function. This fixes simple CDMA operation > mode using 64-bit addressing. > > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Michal Simek > --- >

[PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-07-27 Thread Radhey Shyam Pandey
In AXI CDMA simple mode also pass MSB bits of source and destination address to xilinx_write function. This fixes simple CDMA operation mode using 64-bit addressing. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/dma/xilinx/xilinx_dma.c |6 -- 1 files

[PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-07-27 Thread Radhey Shyam Pandey
In AXI CDMA simple mode also pass MSB bits of source and destination address to xilinx_write function. This fixes simple CDMA operation mode using 64-bit addressing. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/dma/xilinx/xilinx_dma.c |6 -- 1 files