Re: [PATCH 3/3] drm/mediatek: add mt8183 dsi driver support

2019-02-17 Thread Nicolas Boichat
On Sun, Feb 17, 2019 at 10:48 PM Jitao Shi wrote: > > On Thu, 2019-02-14 at 13:54 +0800, Nicolas Boichat wrote: > > On Thu, Feb 14, 2019 at 12:43 PM Jitao Shi wrote: > > > > > > MT8183 dsi has two changes with mt8173. > > > 1. Add the register double buffer control, but we no need it, So make > >

Re: [PATCH 3/3] drm/mediatek: add mt8183 dsi driver support

2019-02-17 Thread Jitao Shi
On Thu, 2019-02-14 at 13:54 +0800, Nicolas Boichat wrote: > On Thu, Feb 14, 2019 at 12:43 PM Jitao Shi wrote: > > > > MT8183 dsi has two changes with mt8173. > > 1. Add the register double buffer control, but we no need it, So make > >it default off. > > Can you describe a little bit more wha

Re: [PATCH 3/3] drm/mediatek: add mt8183 dsi driver support

2019-02-17 Thread Jitao Shi
On Thu, 2019-02-14 at 10:54 +0100, Matthias Brugger wrote: > > On 14/02/2019 05:42, Jitao Shi wrote: > > MT8183 dsi has two changes with mt8173. > > 1. Add the register double buffer control, but we no need it, So make > >it default off. > > 2. Add picture size control. > > > > Signed-off-by:

Re: [PATCH 3/3] drm/mediatek: add mt8183 dsi driver support

2019-02-14 Thread Matthias Brugger
On 14/02/2019 05:42, Jitao Shi wrote: > MT8183 dsi has two changes with mt8173. > 1. Add the register double buffer control, but we no need it, So make >it default off. > 2. Add picture size control. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 20

Re: [PATCH 3/3] drm/mediatek: add mt8183 dsi driver support

2019-02-13 Thread Nicolas Boichat
On Thu, Feb 14, 2019 at 12:43 PM Jitao Shi wrote: > > MT8183 dsi has two changes with mt8173. > 1. Add the register double buffer control, but we no need it, So make >it default off. Can you describe a little bit more what this is about? That's shadow registers, right? > 2. Add picture size

[PATCH 3/3] drm/mediatek: add mt8183 dsi driver support

2019-02-13 Thread Jitao Shi
MT8183 dsi has two changes with mt8173. 1. Add the register double buffer control, but we no need it, So make it default off. 2. Add picture size control. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-)