Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-26 Thread Horst von Brand
Jesper Juhl <[EMAIL PROTECTED]> wrote: > On Wednesday 24 August 2005 22:39, Brian Gerst wrote: > > > > Do this instead: > > char ln[LINE_SIZE], *line; > > > Right, now why didn't I think of that :) > > Jeff: Does the patch below agree with you more? > > > Signed-off-by: Jesper Juhl

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-26 Thread Horst von Brand
Jesper Juhl [EMAIL PROTECTED] wrote: On Wednesday 24 August 2005 22:39, Brian Gerst wrote: Do this instead: char ln[LINE_SIZE], *line; Right, now why didn't I think of that :) Jeff: Does the patch below agree with you more? Signed-off-by: Jesper Juhl [EMAIL PROTECTED] ---

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Sam Ravnborg
On Wed, Aug 24, 2005 at 09:08:53PM +0200, Jesper Juhl wrote: > Convert strtok() use to strsep() in usr/gen_init_cpio.c > > I've compile tested this patch and it compiles fine. > I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and > the resulting kernel boots and runs just

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Paul Jackson
Horst wrote: > > - if ('\n' == *type) { > > + if (!*type || '\n' == *type) { > > Redundant. If *type == '\n', it is certainly != 0. No - I don't think redundant, at least not this change in isolation. Perhaps redundant in light of subsequent code lines, as Jesper notes in his

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Jesper Juhl
On 8/24/05, Horst von Brand <[EMAIL PROTECTED]> wrote: > Jesper Juhl <[EMAIL PROTECTED]> wrote: [snip] > > > - if ('\n' == *type) { > > + if (!*type || '\n' == *type) { > > Redundant. If *type == '\n', it is certainly != 0. Hmm, I added that since if we get past the if

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Jesper Juhl
On Wednesday 24 August 2005 22:39, Brian Gerst wrote: > > Do this instead: > char ln[LINE_SIZE], *line; > Right, now why didn't I think of that :) Jeff: Does the patch below agree with you more? Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- usr/gen_init_cpio.c | 22

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Horst von Brand
Jesper Juhl <[EMAIL PROTECTED]> wrote: > Convert strtok() use to strsep() in usr/gen_init_cpio.c This is userland code... No, I'm not looking it over carfully, just a fast look over. > I've compile tested this patch and it compiles fine. You should be able ti test it then. > I build a

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Brian Gerst
Jesper Juhl wrote: On 8/24/05, Jeff Garzik <[EMAIL PROTECTED]> wrote: Brian Gerst wrote: Jesper Juhl wrote: Convert strtok() use to strsep() in usr/gen_init_cpio.c I've compile tested this patch and it compiles fine. I build a 2.6.13-rc6-mm2 kernel with the patch applied without

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Jesper Juhl
On 8/24/05, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Brian Gerst wrote: > > Jesper Juhl wrote: > > > >> Convert strtok() use to strsep() in usr/gen_init_cpio.c > >> > >> I've compile tested this patch and it compiles fine. > >> I build a 2.6.13-rc6-mm2 kernel with the patch applied without > >>

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Jeff Garzik
Brian Gerst wrote: Jesper Juhl wrote: Convert strtok() use to strsep() in usr/gen_init_cpio.c I've compile tested this patch and it compiles fine. I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and the resulting kernel boots and runs just fine (using it right now).

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Brian Gerst
Jesper Juhl wrote: Convert strtok() use to strsep() in usr/gen_init_cpio.c I've compile tested this patch and it compiles fine. I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and the resulting kernel boots and runs just fine (using it right now). But despite this basic

[PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Jesper Juhl
Convert strtok() use to strsep() in usr/gen_init_cpio.c I've compile tested this patch and it compiles fine. I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and the resulting kernel boots and runs just fine (using it right now). But despite this basic testing it would

[PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Jesper Juhl
Convert strtok() use to strsep() in usr/gen_init_cpio.c I've compile tested this patch and it compiles fine. I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and the resulting kernel boots and runs just fine (using it right now). But despite this basic testing it would

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Brian Gerst
Jesper Juhl wrote: Convert strtok() use to strsep() in usr/gen_init_cpio.c I've compile tested this patch and it compiles fine. I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and the resulting kernel boots and runs just fine (using it right now). But despite this basic

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Jeff Garzik
Brian Gerst wrote: Jesper Juhl wrote: Convert strtok() use to strsep() in usr/gen_init_cpio.c I've compile tested this patch and it compiles fine. I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and the resulting kernel boots and runs just fine (using it right now).

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Jesper Juhl
On 8/24/05, Jeff Garzik [EMAIL PROTECTED] wrote: Brian Gerst wrote: Jesper Juhl wrote: Convert strtok() use to strsep() in usr/gen_init_cpio.c I've compile tested this patch and it compiles fine. I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and the

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Brian Gerst
Jesper Juhl wrote: On 8/24/05, Jeff Garzik [EMAIL PROTECTED] wrote: Brian Gerst wrote: Jesper Juhl wrote: Convert strtok() use to strsep() in usr/gen_init_cpio.c I've compile tested this patch and it compiles fine. I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems,

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Horst von Brand
Jesper Juhl [EMAIL PROTECTED] wrote: Convert strtok() use to strsep() in usr/gen_init_cpio.c This is userland code... No, I'm not looking it over carfully, just a fast look over. I've compile tested this patch and it compiles fine. You should be able ti test it then. I build a

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Jesper Juhl
On Wednesday 24 August 2005 22:39, Brian Gerst wrote: Do this instead: char ln[LINE_SIZE], *line; Right, now why didn't I think of that :) Jeff: Does the patch below agree with you more? Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- usr/gen_init_cpio.c | 22

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Jesper Juhl
On 8/24/05, Horst von Brand [EMAIL PROTECTED] wrote: Jesper Juhl [EMAIL PROTECTED] wrote: [snip] - if ('\n' == *type) { + if (!*type || '\n' == *type) { Redundant. If *type == '\n', it is certainly != 0. Hmm, I added that since if we get past the if above it,

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Paul Jackson
Horst wrote: - if ('\n' == *type) { + if (!*type || '\n' == *type) { Redundant. If *type == '\n', it is certainly != 0. No - I don't think redundant, at least not this change in isolation. Perhaps redundant in light of subsequent code lines, as Jesper notes in his

Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

2005-08-24 Thread Sam Ravnborg
On Wed, Aug 24, 2005 at 09:08:53PM +0200, Jesper Juhl wrote: Convert strtok() use to strsep() in usr/gen_init_cpio.c I've compile tested this patch and it compiles fine. I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and the resulting kernel boots and runs just fine