Re: [f2fs-dev] [PATCH 3/3] f2fs: flush stale issued discard candidates

2018-12-18 Thread Chao Yu
On 2018/12/19 6:43, Jaegeuk Kim wrote: > On 12/18, Chao Yu wrote: >> On 2018/12/14 13:01, Jaegeuk Kim wrote: >>> Sometimes, I could observe # of issuing_discard to be 1 which blocks >>> background >>> jobs due to is_idle()=false. >>> The only way to get out of it was to trigger gc_urgent. This

Re: [f2fs-dev] [PATCH 3/3] f2fs: flush stale issued discard candidates

2018-12-18 Thread Jaegeuk Kim
On 12/18, Chao Yu wrote: > On 2018/12/14 13:01, Jaegeuk Kim wrote: > > Sometimes, I could observe # of issuing_discard to be 1 which blocks > > background > > jobs due to is_idle()=false. > > The only way to get out of it was to trigger gc_urgent. This patch avoids > > that > > by checking any

Re: [f2fs-dev] [PATCH 3/3] f2fs: flush stale issued discard candidates

2018-12-18 Thread Chao Yu
On 2018/12/14 13:01, Jaegeuk Kim wrote: > Sometimes, I could observe # of issuing_discard to be 1 which blocks > background > jobs due to is_idle()=false. > The only way to get out of it was to trigger gc_urgent. This patch avoids that > by checking any candidates as done in the list. Well, as

[PATCH 3/3] f2fs: flush stale issued discard candidates

2018-12-13 Thread Jaegeuk Kim
Sometimes, I could observe # of issuing_discard to be 1 which blocks background jobs due to is_idle()=false. The only way to get out of it was to trigger gc_urgent. This patch avoids that by checking any candidates as done in the list. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 4