Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

2020-09-21 Thread Wolfram Sang
On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote: > CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't need to > handle the case where Device Tree is not supported. > > Signed-off-by: Paul Cercueil Applied to for-next, thanks! signature.asc Description: PGP signatur

Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

2020-09-21 Thread Wolfram Sang
> Indeed, because jz4780_i2c_of_matches isn't within a CONFIG_OF ifdef > as is sometimes done and is when you need of_match_ptr(). IMO, the > commit msg should have something like "The driver is only used with > CONFIG_OF enabled, so of_match_ptr() is not necessary. > jz4780_i2c_of_matches is alwa

Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

2020-09-15 Thread Rob Herring
On Tue, Sep 15, 2020 at 4:07 AM Paul Cercueil wrote: > > Hi Rob, > > Le lun. 14 sept. 2020 à 16:12, Rob Herring a écrit : > > On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote: > >> CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't > >> need to > >> handle the case wh

Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

2020-09-15 Thread Paul Cercueil
Le mar. 15 sept. 2020 à 10:03, Rob Herring a écrit : On Tue, Sep 15, 2020 at 4:07 AM Paul Cercueil wrote: Hi Rob, Le lun. 14 sept. 2020 à 16:12, Rob Herring a écrit : > On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote: >> CONFIG_OF is selected by CONFIG_MACH_INGENIC,

Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

2020-09-15 Thread Rob Herring
On Tue, Sep 15, 2020 at 10:07 AM Paul Cercueil wrote: > > > > Le mar. 15 sept. 2020 à 10:03, Rob Herring a écrit : > > On Tue, Sep 15, 2020 at 4:07 AM Paul Cercueil > > wrote: > >> > >> Hi Rob, > >> > >> Le lun. 14 sept. 2020 à 16:12, Rob Herring a > >> écrit : > >> > On Fri, Sep 04, 2020 at

Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

2020-09-15 Thread Paul Cercueil
Hi Rob, Le lun. 14 sept. 2020 à 16:12, Rob Herring a écrit : On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote: CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't need to handle the case where Device Tree is not supported. What about COMPILE_TEST? If not supporte

Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

2020-09-14 Thread Rob Herring
On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote: > CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't need to > handle the case where Device Tree is not supported. What about COMPILE_TEST? If not supported, why not? > > Signed-off-by: Paul Cercueil > --- > drivers/i

[PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

2020-09-04 Thread Paul Cercueil
CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't need to handle the case where Device Tree is not supported. Signed-off-by: Paul Cercueil --- drivers/i2c/busses/i2c-jz4780.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-jz4780.c b/driv