Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-29 Thread Guenter Roeck
On Mon, Dec 29, 2014 at 01:50:22PM +0100, Gabriele Mazzotta wrote: > On Monday 29 December 2014 13:22:52 Pali Rohár wrote: > > On Sunday 28 December 2014 17:17:14 Gabriele Mazzotta wrote: > > > OK, I wanted to double check in case I had something missing. > > > > > > Patches tested on my XPS13: th

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-29 Thread Gabriele Mazzotta
On Monday 29 December 2014 13:22:52 Pali Rohár wrote: > On Sunday 28 December 2014 17:17:14 Gabriele Mazzotta wrote: > > OK, I wanted to double check in case I had something missing. > > > > Patches tested on my XPS13: the correct values for fan_mult > > and fan_man are automatically selected. >

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-29 Thread Pali Rohár
On Sunday 28 December 2014 17:17:14 Gabriele Mazzotta wrote: > OK, I wanted to double check in case I had something missing. > > Patches tested on my XPS13: the correct values for fan_mult > and fan_man are automatically selected. Great. Are there any other problems? Now probe time when loading

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Gabriele Mazzotta
On Sunday 28 December 2014 17:07:43 Pali Rohár wrote: > On Sunday 28 December 2014 17:02:35 Gabriele Mazzotta wrote: > > On Sunday 28 December 2014 16:48:54 Pali Rohár wrote: > > > On Sunday 28 December 2014 16:25:21 Gabriele Mazzotta wrote: > > > > On Sunday 28 December 2014 09:46:19 Pali Rohár wr

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Pali Rohár
On Sunday 28 December 2014 17:02:35 Gabriele Mazzotta wrote: > On Sunday 28 December 2014 16:48:54 Pali Rohár wrote: > > On Sunday 28 December 2014 16:25:21 Gabriele Mazzotta wrote: > > > On Sunday 28 December 2014 09:46:19 Pali Rohár wrote: > > > > Ok, here are new patches for testing... Those you

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Gabriele Mazzotta
On Sunday 28 December 2014 16:48:54 Pali Rohár wrote: > On Sunday 28 December 2014 16:25:21 Gabriele Mazzotta wrote: > > On Sunday 28 December 2014 09:46:19 Pali Rohár wrote: > > > Ok, here are new patches for testing... Those you are still > > > reading this email thread and have your Dell machine

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Pali Rohár
On Sunday 28 December 2014 16:25:21 Gabriele Mazzotta wrote: > On Sunday 28 December 2014 09:46:19 Pali Rohár wrote: > > Ok, here are new patches for testing... Those you are still > > reading this email thread and have your Dell machines near, > > can you test them (ideally with disabling dmi conf

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Gabriele Mazzotta
On Sunday 28 December 2014 09:46:19 Pali Rohár wrote: > Ok, here are new patches for testing... Those you are still reading this > email thread and have your Dell > machines near, can you test them (ideally with disabling dmi config data)? Could you please tell me exactly against what should I a

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Pali Rohár
Ok, here are new patches for testing... Those you are still reading this email thread and have your Dell machines near, can you test them (ideally with disabling dmi config data)? diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c index 8ec4c37..d6e8a26 100644 --- a/drivers/char/i8k.c +++ b/dr

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Guenter Roeck
On Sun, Dec 28, 2014 at 09:22:29AM +0100, Pali Rohár wrote: > On Saturday 27 December 2014 15:13:28 Gabriele Mazzotta wrote: > > On Thursday 25 December 2014 22:54:34 Gabriele Mazzotta wrote: > > > On Thursday 18 December 2014 12:08:58 Pali Rohár wrote: > > > > On Wednesday 10 December 2014 14:32:1

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Pali Rohár
On Saturday 27 December 2014 15:13:28 Gabriele Mazzotta wrote: > On Thursday 25 December 2014 22:54:34 Gabriele Mazzotta wrote: > > On Thursday 18 December 2014 12:08:58 Pali Rohár wrote: > > > On Wednesday 10 December 2014 14:32:16 Gabriele Mazzotta wrote: > > > > On Wednesday 10 December 2014 12

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-27 Thread Gabriele Mazzotta
On Thursday 25 December 2014 22:54:34 Gabriele Mazzotta wrote: > On Thursday 18 December 2014 12:08:58 Pali Rohár wrote: > > On Wednesday 10 December 2014 14:32:16 Gabriele Mazzotta wrote: > > > On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote: > > > > On Tuesday 09 December 2014 21:07:01 Pa

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-25 Thread Gabriele Mazzotta
On Thursday 18 December 2014 12:08:58 Pali Rohár wrote: > On Wednesday 10 December 2014 14:32:16 Gabriele Mazzotta wrote: > > On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote: > > > On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: > > > > Now we have autodetection code for fan multipli

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Valdis . Kletnieks
On Thu, 18 Dec 2014 17:34:56 +0100, Pali Rohár said: > Thanks for testing. Anyway I would like to know if your dell > machine supports i8k_get_fan_nominal_rpm(). Can you test without > above 4 lines patch? I'll give that a try this evening.. pgp06z7fPJJ3Q.pgp Description: PGP signature

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Pali Rohár
On Thursday 18 December 2014 16:08:51 valdis.kletni...@vt.edu wrote: > On Thu, 18 Dec 2014 12:08:58 +0100, Pali Rohár said: > > So your BIOS cannot report nominal_rpm and because your > > machine=20 is not in dmi list, all 3 patches do nothing for > > your machine. > > > > But you need to set mul

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Valdis . Kletnieks
On Thu, 18 Dec 2014 12:08:58 +0100, Pali Rohár said: > So your BIOS cannot report nominal_rpm and because your machine=20 > is not in dmi list, all 3 patches do nothing for your machine. > > But you need to set multiplier to 1, right? > > What about this patch? (on top of 3/3) > > --- a/drivers

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Pali Rohár
On Wednesday 17 December 2014 19:20:21 Steven Honeyman wrote: > On 17 December 2014 at 17:54, Pali Rohár wrote: > > On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote: > >> On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: > >> > Now we have autodetection code for fan multiplier and > >

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Pali Rohár
On Wednesday 10 December 2014 14:32:16 Gabriele Mazzotta wrote: > On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote: > > On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: > > > Now we have autodetection code for fan multiplier and > > > maximal fan speed so we do not need to have those >

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Valdis . Kletnieks
On Wed, 17 Dec 2014 18:20:21 +, Steven Honeyman said: > On 17 December 2014 at 17:54, Pali Rohár wrote: > >> > Dell Latitude E6540 > >> Can somebody else with dell laptops test this patch series? > > > > Steven Honeyman, can you test this autodetection patch on your > > Latitude E6540? I'm

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-17 Thread Steven Honeyman
On 17 December 2014 at 17:54, Pali Rohár wrote: > On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote: >> On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: >> > Now we have autodetection code for fan multiplier and >> > maximal fan speed so we do not need to have those constants >> > for

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-17 Thread Pali Rohár
On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote: > On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: > > Now we have autodetection code for fan multiplier and > > maximal fan speed so we do not need to have those constants > > for each laptop in kernel driver code. > > > > Signed-off-

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-10 Thread Gabriele Mazzotta
On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: > Now we have autodetection code for fan multiplier and maximal fan speed so we > do > not need to have those constants for each laptop in kernel driver code. > > Signed-off-by: Pali Rohár > --- > !!!Please do not apply this patch until all

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-10 Thread Gabriele Mazzotta
On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote: > On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: > > Now we have autodetection code for fan multiplier and maximal > > fan speed so we do not need to have those constants for each > > laptop in kernel driver code. > > > > Signed-off-

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-10 Thread Pali Rohár
On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: > Now we have autodetection code for fan multiplier and maximal > fan speed so we do not need to have those constants for each > laptop in kernel driver code. > > Signed-off-by: Pali Rohár > --- > !!!Please do not apply this patch until all a

[PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-09 Thread Pali Rohár
Now we have autodetection code for fan multiplier and maximal fan speed so we do not need to have those constants for each laptop in kernel driver code. Signed-off-by: Pali Rohár --- !!!Please do not apply this patch until all affected machines will be tested!!! I tested autodetection code only