On Thu, 19 Mar 2015, Jassi Brar wrote:
> On Thu, Mar 19, 2015 at 2:47 PM, Lee Jones wrote:
> > On Thu, 19 Mar 2015, Jassi Brar wrote:
> >
> >> On Wed, Mar 18, 2015 at 9:04 PM, Lee Jones wrote:
> >> > On Wed, 18 Mar 2015, Jassi Brar wrote:
> >> >
> >> >> On Wed, Mar 18, 2015 at 6:47 PM, Lee
On Thu, 19 Mar 2015, Jassi Brar wrote:
On Thu, Mar 19, 2015 at 2:47 PM, Lee Jones lee.jo...@linaro.org wrote:
On Thu, 19 Mar 2015, Jassi Brar wrote:
On Wed, Mar 18, 2015 at 9:04 PM, Lee Jones lee.jo...@linaro.org wrote:
On Wed, 18 Mar 2015, Jassi Brar wrote:
On Wed, Mar 18, 2015
On Thu, Mar 19, 2015 at 3:27 PM, Lee Jones wrote:
> On Thu, 19 Mar 2015, Jassi Brar wrote:
>
>> And also no header that's included by exactly one file.
>
> So you also want me to drag in all of the controller structs into the
> driver?
>
Yes, please. Why have structures, internal to a code, in a
On Thu, Mar 19, 2015 at 2:47 PM, Lee Jones wrote:
> On Thu, 19 Mar 2015, Jassi Brar wrote:
>
>> On Wed, Mar 18, 2015 at 9:04 PM, Lee Jones wrote:
>> > On Wed, 18 Mar 2015, Jassi Brar wrote:
>> >
>> >> On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones wrote:
>> >> > On Tue, 03 Mar 2015, Jassi Brar
On Thu, 19 Mar 2015, Jassi Brar wrote:
> On Wed, Mar 18, 2015 at 8:56 PM, Lee Jones wrote:
> > On Wed, 18 Mar 2015, Jassi Brar wrote:
>
> >> >> > + mbox->irq =
> >> >> > irq_create_mapping(mbinst->irq_domain,
> >> >> > +
On Thu, 19 Mar 2015, Jassi Brar wrote:
> On Wed, Mar 18, 2015 at 9:04 PM, Lee Jones wrote:
> > On Wed, 18 Mar 2015, Jassi Brar wrote:
> >
> >> On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones wrote:
> >> > On Tue, 03 Mar 2015, Jassi Brar wrote:
> >> >
> >> >> On 3 March 2015 at 17:04, Arnd Bergmann
On Thu, 19 Mar 2015, Jassi Brar wrote:
On Wed, Mar 18, 2015 at 9:04 PM, Lee Jones lee.jo...@linaro.org wrote:
On Wed, 18 Mar 2015, Jassi Brar wrote:
On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones lee.jo...@linaro.org wrote:
On Tue, 03 Mar 2015, Jassi Brar wrote:
On 3 March 2015 at
On Thu, 19 Mar 2015, Jassi Brar wrote:
On Wed, Mar 18, 2015 at 8:56 PM, Lee Jones lee.jo...@linaro.org wrote:
On Wed, 18 Mar 2015, Jassi Brar wrote:
+ mbox-irq =
irq_create_mapping(mbinst-irq_domain,
+
On Thu, Mar 19, 2015 at 3:27 PM, Lee Jones lee.jo...@linaro.org wrote:
On Thu, 19 Mar 2015, Jassi Brar wrote:
And also no header that's included by exactly one file.
So you also want me to drag in all of the controller structs into the
driver?
Yes, please. Why have structures, internal to a
On Thu, Mar 19, 2015 at 2:47 PM, Lee Jones lee.jo...@linaro.org wrote:
On Thu, 19 Mar 2015, Jassi Brar wrote:
On Wed, Mar 18, 2015 at 9:04 PM, Lee Jones lee.jo...@linaro.org wrote:
On Wed, 18 Mar 2015, Jassi Brar wrote:
On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones lee.jo...@linaro.org
On Wed, Mar 18, 2015 at 9:04 PM, Lee Jones wrote:
> On Wed, 18 Mar 2015, Jassi Brar wrote:
>
>> On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones wrote:
>> > On Tue, 03 Mar 2015, Jassi Brar wrote:
>> >
>> >> On 3 March 2015 at 17:04, Arnd Bergmann wrote:
>> >> > On Tuesday 03 March 2015 10:41:23 Lee
On Wed, Mar 18, 2015 at 8:56 PM, Lee Jones wrote:
> On Wed, 18 Mar 2015, Jassi Brar wrote:
>> >> > + mbox->irq =
>> >> > irq_create_mapping(mbinst->irq_domain,
>> >> > + mbox->rx_id);
>> >> >
>> >> simply assigning same
On Wed, 18 Mar 2015, Jassi Brar wrote:
> On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones wrote:
> > On Tue, 03 Mar 2015, Jassi Brar wrote:
> >
> >> On 3 March 2015 at 17:04, Arnd Bergmann wrote:
> >> > On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
> >> >> +
> >> >> +/*
> >> >> + * struct
On Wed, 18 Mar 2015, Jassi Brar wrote:
> On Wed, Mar 18, 2015 at 6:42 PM, Lee Jones wrote:
> > On Wed, 04 Mar 2015, Jassi Brar wrote:
> >
> >> > +
> >> > + if ((!data) || (!sti_mbox_chan_is_tx(mbox)))
> >> >
> >> nit: too much protection.
> >
> > What makes you think that?
> >
> Usually we
On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones wrote:
> On Tue, 03 Mar 2015, Jassi Brar wrote:
>
>> On 3 March 2015 at 17:04, Arnd Bergmann wrote:
>> > On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
>> >> +
>> >> +/*
>> >> + * struct sti_mbox_msg - sti mailbox message description
>> >> + *
On Wed, Mar 18, 2015 at 6:42 PM, Lee Jones wrote:
> On Wed, 04 Mar 2015, Jassi Brar wrote:
>
>> > +
>> > + if ((!data) || (!sti_mbox_chan_is_tx(mbox)))
>> >
>> nit: too much protection.
>
> What makes you think that?
>
Usually we write
if (!data ||
On Tue, 03 Mar 2015, Jassi Brar wrote:
> On 3 March 2015 at 17:04, Arnd Bergmann wrote:
> > On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
> >> +
> >> +/*
> >> + * struct sti_mbox_msg - sti mailbox message description
> >> + * @dsize: data payload size
> >> + * @pdata:
On Wed, 04 Mar 2015, Jassi Brar wrote:
> On 3 March 2015 at 16:11, Lee Jones wrote:
>
> > ---
> > drivers/mailbox/Kconfig | 7 +
> > drivers/mailbox/Makefile | 2 +
> > drivers/mailbox/mailbox-sti.c | 664
> > ++
> >
On Wed, Mar 18, 2015 at 6:42 PM, Lee Jones lee.jo...@linaro.org wrote:
On Wed, 04 Mar 2015, Jassi Brar wrote:
+
+ if ((!data) || (!sti_mbox_chan_is_tx(mbox)))
nit: too much protection.
What makes you think that?
Usually we write
if (!data ||
On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones lee.jo...@linaro.org wrote:
On Tue, 03 Mar 2015, Jassi Brar wrote:
On 3 March 2015 at 17:04, Arnd Bergmann a...@arndb.de wrote:
On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
+
+/*
+ * struct sti_mbox_msg - sti mailbox message description
On Tue, 03 Mar 2015, Jassi Brar wrote:
On 3 March 2015 at 17:04, Arnd Bergmann a...@arndb.de wrote:
On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
+
+/*
+ * struct sti_mbox_msg - sti mailbox message description
+ * @dsize: data payload size
+ * @pdata:
On Wed, 04 Mar 2015, Jassi Brar wrote:
On 3 March 2015 at 16:11, Lee Jones lee.jo...@linaro.org wrote:
---
drivers/mailbox/Kconfig | 7 +
drivers/mailbox/Makefile | 2 +
drivers/mailbox/mailbox-sti.c | 664
++
On Wed, 18 Mar 2015, Jassi Brar wrote:
On Wed, Mar 18, 2015 at 6:42 PM, Lee Jones lee.jo...@linaro.org wrote:
On Wed, 04 Mar 2015, Jassi Brar wrote:
+
+ if ((!data) || (!sti_mbox_chan_is_tx(mbox)))
nit: too much protection.
What makes you think that?
Usually we write
On Wed, 18 Mar 2015, Jassi Brar wrote:
On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones lee.jo...@linaro.org wrote:
On Tue, 03 Mar 2015, Jassi Brar wrote:
On 3 March 2015 at 17:04, Arnd Bergmann a...@arndb.de wrote:
On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
+
+/*
+ * struct
On Wed, Mar 18, 2015 at 8:56 PM, Lee Jones lee.jo...@linaro.org wrote:
On Wed, 18 Mar 2015, Jassi Brar wrote:
+ mbox-irq =
irq_create_mapping(mbinst-irq_domain,
+ mbox-rx_id);
simply assigning same IRQ to
On Wed, Mar 18, 2015 at 9:04 PM, Lee Jones lee.jo...@linaro.org wrote:
On Wed, 18 Mar 2015, Jassi Brar wrote:
On Wed, Mar 18, 2015 at 6:47 PM, Lee Jones lee.jo...@linaro.org wrote:
On Tue, 03 Mar 2015, Jassi Brar wrote:
On 3 March 2015 at 17:04, Arnd Bergmann a...@arndb.de wrote:
On
On 3 March 2015 at 16:11, Lee Jones wrote:
> ---
> drivers/mailbox/Kconfig | 7 +
> drivers/mailbox/Makefile | 2 +
> drivers/mailbox/mailbox-sti.c | 664
> ++
> include/linux/mailbox_sti.h | 128
>
How about the header in
On 3 March 2015 at 16:11, Lee Jones lee.jo...@linaro.org wrote:
---
drivers/mailbox/Kconfig | 7 +
drivers/mailbox/Makefile | 2 +
drivers/mailbox/mailbox-sti.c | 664
++
include/linux/mailbox_sti.h | 128
How about the
On 3 March 2015 at 17:04, Arnd Bergmann wrote:
> On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
>> +
>> +/*
>> + * struct sti_mbox_msg - sti mailbox message description
>> + * @dsize: data payload size
>> + * @pdata: message data payload
>> + */
>> +struct sti_mbox_msg
On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
> +
> +/*
> + * struct sti_mbox_msg - sti mailbox message description
> + * @dsize: data payload size
> + * @pdata: message data payload
> + */
> +struct sti_mbox_msg {
> + u32 dsize;
> + u8
ST's platforms currently support a maximum of 5 channels, one for
each of the co-processors situated on the platforms. The
difficulty with this IP is the fact that there is only one RX IRQ,
which requires some special handling within the driver. In this
implementation channel 1, which is always
On 3 March 2015 at 17:04, Arnd Bergmann a...@arndb.de wrote:
On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
+
+/*
+ * struct sti_mbox_msg - sti mailbox message description
+ * @dsize: data payload size
+ * @pdata: message data payload
+ */
+struct sti_mbox_msg {
ST's platforms currently support a maximum of 5 channels, one for
each of the co-processors situated on the platforms. The
difficulty with this IP is the fact that there is only one RX IRQ,
which requires some special handling within the driver. In this
implementation channel 1, which is always
On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
+
+/*
+ * struct sti_mbox_msg - sti mailbox message description
+ * @dsize: data payload size
+ * @pdata: message data payload
+ */
+struct sti_mbox_msg {
+ u32 dsize;
+ u8
34 matches
Mail list logo
