Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

2014-11-20 Thread Javier Martinez Canillas
Hello Lee, On 11/20/2014 02:27 PM, Lee Jones wrote: >> > By the sounds of the description, it doesn't seem as though this >> > driver lives in MFD. I suggest another home, such as drivers/led. >> > >> >> You are right. As I said in the other email, I'll move it to >> drivers/platform/chrome/

Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

2014-11-20 Thread Lee Jones
On Thu, 20 Nov 2014, Javier Martinez Canillas wrote: > Hello Lee, > > On 11/18/2014 03:22 PM, Lee Jones wrote: > >> --- > >> drivers/mfd/Makefile | 2 +- > >> drivers/mfd/cros_ec_dev.c | 2 + > >> drivers/mfd/cros_ec_dev.h | 3 + > >> drivers/mfd/cros_ec_lightbar.c |

Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

2014-11-20 Thread Javier Martinez Canillas
Hello Lee, On 11/18/2014 03:22 PM, Lee Jones wrote: >> --- >> drivers/mfd/Makefile | 2 +- >> drivers/mfd/cros_ec_dev.c | 2 + >> drivers/mfd/cros_ec_dev.h | 3 + >> drivers/mfd/cros_ec_lightbar.c | 347 >> + > > By the sounds of

Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

2014-11-20 Thread Javier Martinez Canillas
Hello Lee, On 11/18/2014 03:22 PM, Lee Jones wrote: --- drivers/mfd/Makefile | 2 +- drivers/mfd/cros_ec_dev.c | 2 + drivers/mfd/cros_ec_dev.h | 3 + drivers/mfd/cros_ec_lightbar.c | 347 + By the sounds of the

Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

2014-11-20 Thread Lee Jones
On Thu, 20 Nov 2014, Javier Martinez Canillas wrote: Hello Lee, On 11/18/2014 03:22 PM, Lee Jones wrote: --- drivers/mfd/Makefile | 2 +- drivers/mfd/cros_ec_dev.c | 2 + drivers/mfd/cros_ec_dev.h | 3 + drivers/mfd/cros_ec_lightbar.c | 347

Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

2014-11-20 Thread Javier Martinez Canillas
Hello Lee, On 11/20/2014 02:27 PM, Lee Jones wrote: By the sounds of the description, it doesn't seem as though this driver lives in MFD. I suggest another home, such as drivers/led. You are right. As I said in the other email, I'll move it to drivers/platform/chrome/ which seems like

Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

2014-11-18 Thread Lee Jones
On Mon, 17 Nov 2014, Javier Martinez Canillas wrote: > From: Bill Richardson > > This adds some sysfs entries to provide userspace control of the > four-element LED "lightbar" on the Chromebook Pixel. This only instantiates > the lightbar controls if the device actually exists. > > To prevent

Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

2014-11-18 Thread Lee Jones
On Mon, 17 Nov 2014, Javier Martinez Canillas wrote: From: Bill Richardson wfric...@chromium.org This adds some sysfs entries to provide userspace control of the four-element LED lightbar on the Chromebook Pixel. This only instantiates the lightbar controls if the device actually exists.

[PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

2014-11-17 Thread Javier Martinez Canillas
From: Bill Richardson This adds some sysfs entries to provide userspace control of the four-element LED "lightbar" on the Chromebook Pixel. This only instantiates the lightbar controls if the device actually exists. To prevent DoS attacks, this interface is limited to 20 accesses/second,

[PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

2014-11-17 Thread Javier Martinez Canillas
From: Bill Richardson wfric...@chromium.org This adds some sysfs entries to provide userspace control of the four-element LED lightbar on the Chromebook Pixel. This only instantiates the lightbar controls if the device actually exists. To prevent DoS attacks, this interface is limited to 20