Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-19 Thread Yang Shi
On 10/19/17 12:28 AM, Michal Hocko wrote: On Tue 17-10-17 15:39:08, David Rientjes wrote: On Wed, 18 Oct 2017, Yang Shi wrote: Yes, this should catch occurrences of "huge unreclaimable slabs", right? Yes, it sounds so. Although single "huge" unreclaimable slab might not result in

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-19 Thread Yang Shi
On 10/19/17 12:28 AM, Michal Hocko wrote: On Tue 17-10-17 15:39:08, David Rientjes wrote: On Wed, 18 Oct 2017, Yang Shi wrote: Yes, this should catch occurrences of "huge unreclaimable slabs", right? Yes, it sounds so. Although single "huge" unreclaimable slab might not result in

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-19 Thread Michal Hocko
On Tue 17-10-17 15:39:08, David Rientjes wrote: > On Wed, 18 Oct 2017, Yang Shi wrote: > > > > Yes, this should catch occurrences of "huge unreclaimable slabs", right? > > > > Yes, it sounds so. Although single "huge" unreclaimable slab might not > > result > > in excessive slabs use in a

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-19 Thread Michal Hocko
On Tue 17-10-17 15:39:08, David Rientjes wrote: > On Wed, 18 Oct 2017, Yang Shi wrote: > > > > Yes, this should catch occurrences of "huge unreclaimable slabs", right? > > > > Yes, it sounds so. Although single "huge" unreclaimable slab might not > > result > > in excessive slabs use in a

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-18 Thread Yang Shi
On 10/17/17 3:39 PM, David Rientjes wrote: On Wed, 18 Oct 2017, Yang Shi wrote: Yes, this should catch occurrences of "huge unreclaimable slabs", right? Yes, it sounds so. Although single "huge" unreclaimable slab might not result in excessive slabs use in a whole, but this would help to

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-18 Thread Yang Shi
On 10/17/17 3:39 PM, David Rientjes wrote: On Wed, 18 Oct 2017, Yang Shi wrote: Yes, this should catch occurrences of "huge unreclaimable slabs", right? Yes, it sounds so. Although single "huge" unreclaimable slab might not result in excessive slabs use in a whole, but this would help to

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread David Rientjes
On Wed, 18 Oct 2017, Yang Shi wrote: > > Yes, this should catch occurrences of "huge unreclaimable slabs", right? > > Yes, it sounds so. Although single "huge" unreclaimable slab might not result > in excessive slabs use in a whole, but this would help to filter out "small" > unreclaimable slab.

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread David Rientjes
On Wed, 18 Oct 2017, Yang Shi wrote: > > Yes, this should catch occurrences of "huge unreclaimable slabs", right? > > Yes, it sounds so. Although single "huge" unreclaimable slab might not result > in excessive slabs use in a whole, but this would help to filter out "small" > unreclaimable slab.

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread Yang Shi
On 10/17/17 2:50 PM, David Rientjes wrote: On Wed, 18 Oct 2017, Yang Shi wrote: Please simply dump statistics for all slab caches where the memory footprint is greater than 5% of system memory. Unconditionally? User controlable? Unconditionally, it's a single line of output per slab

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread Yang Shi
On 10/17/17 2:50 PM, David Rientjes wrote: On Wed, 18 Oct 2017, Yang Shi wrote: Please simply dump statistics for all slab caches where the memory footprint is greater than 5% of system memory. Unconditionally? User controlable? Unconditionally, it's a single line of output per slab

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread David Rientjes
On Wed, 18 Oct 2017, Yang Shi wrote: > > > > Please simply dump statistics for all slab caches where the memory > > > > footprint is greater than 5% of system memory. > > > > > > Unconditionally? User controlable? > > > > Unconditionally, it's a single line of output per slab cache and there >

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread David Rientjes
On Wed, 18 Oct 2017, Yang Shi wrote: > > > > Please simply dump statistics for all slab caches where the memory > > > > footprint is greater than 5% of system memory. > > > > > > Unconditionally? User controlable? > > > > Unconditionally, it's a single line of output per slab cache and there >

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread Yang Shi
On 10/17/17 1:59 PM, David Rientjes wrote: On Tue, 17 Oct 2017, Michal Hocko wrote: On Mon 16-10-17 17:15:31, David Rientjes wrote: Please simply dump statistics for all slab caches where the memory footprint is greater than 5% of system memory. Unconditionally? User controlable?

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread Yang Shi
On 10/17/17 1:59 PM, David Rientjes wrote: On Tue, 17 Oct 2017, Michal Hocko wrote: On Mon 16-10-17 17:15:31, David Rientjes wrote: Please simply dump statistics for all slab caches where the memory footprint is greater than 5% of system memory. Unconditionally? User controlable?

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread David Rientjes
On Tue, 17 Oct 2017, Michal Hocko wrote: > On Mon 16-10-17 17:15:31, David Rientjes wrote: > > Please simply dump statistics for all slab caches where the memory > > footprint is greater than 5% of system memory. > > Unconditionally? User controlable? Unconditionally, it's a single line of

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread David Rientjes
On Tue, 17 Oct 2017, Michal Hocko wrote: > On Mon 16-10-17 17:15:31, David Rientjes wrote: > > Please simply dump statistics for all slab caches where the memory > > footprint is greater than 5% of system memory. > > Unconditionally? User controlable? Unconditionally, it's a single line of

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread Michal Hocko
On Mon 16-10-17 17:15:31, David Rientjes wrote: > Please simply dump statistics for all slab caches where the memory > footprint is greater than 5% of system memory. Unconditionally? User controlable? -- Michal Hocko SUSE Labs

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-17 Thread Michal Hocko
On Mon 16-10-17 17:15:31, David Rientjes wrote: > Please simply dump statistics for all slab caches where the memory > footprint is greater than 5% of system memory. Unconditionally? User controlable? -- Michal Hocko SUSE Labs

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-16 Thread David Rientjes
On Wed, 11 Oct 2017, Yang Shi wrote: > @@ -161,6 +162,25 @@ static bool oom_unkillable_task(struct task_struct *p, > return false; > } > > +/* > + * Print out unreclaimble slabs info when unreclaimable slabs amount is > greater > + * than all user memory (LRU pages) > + */ > +static

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-16 Thread David Rientjes
On Wed, 11 Oct 2017, Yang Shi wrote: > @@ -161,6 +162,25 @@ static bool oom_unkillable_task(struct task_struct *p, > return false; > } > > +/* > + * Print out unreclaimble slabs info when unreclaimable slabs amount is > greater > + * than all user memory (LRU pages) > + */ > +static

[PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-10 Thread Yang Shi
Kernel may panic when oom happens without killable process sometimes it is caused by huge unreclaimable slabs used by kernel. Although kdump could help debug such problem, however, kdump is not available on all architectures and it might be malfunction sometime. And, since kernel already panic it

[PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-10 Thread Yang Shi
Kernel may panic when oom happens without killable process sometimes it is caused by huge unreclaimable slabs used by kernel. Although kdump could help debug such problem, however, kdump is not available on all architectures and it might be malfunction sometime. And, since kernel already panic it

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Yang Shi
On 10/9/17 11:53 AM, Yang Shi wrote: On 10/8/17 11:36 PM, Michal Hocko wrote: On Mon 09-10-17 08:33:16, Michal Hocko wrote: On Sat 07-10-17 00:37:55, Yang Shi wrote: On 10/6/17 2:37 AM, Michal Hocko wrote: On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Yang Shi
On 10/9/17 11:53 AM, Yang Shi wrote: On 10/8/17 11:36 PM, Michal Hocko wrote: On Mon 09-10-17 08:33:16, Michal Hocko wrote: On Sat 07-10-17 00:37:55, Yang Shi wrote: On 10/6/17 2:37 AM, Michal Hocko wrote: On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Yang Shi
On 10/8/17 11:36 PM, Michal Hocko wrote: On Mon 09-10-17 08:33:16, Michal Hocko wrote: On Sat 07-10-17 00:37:55, Yang Shi wrote: On 10/6/17 2:37 AM, Michal Hocko wrote: On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] + list_for_each_entry_safe(s, s2, _caches, list) { +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Yang Shi
On 10/8/17 11:36 PM, Michal Hocko wrote: On Mon 09-10-17 08:33:16, Michal Hocko wrote: On Sat 07-10-17 00:37:55, Yang Shi wrote: On 10/6/17 2:37 AM, Michal Hocko wrote: On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] + list_for_each_entry_safe(s, s2, _caches, list) { +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Yang Shi
On 10/8/17 11:36 PM, Michal Hocko wrote: On Mon 09-10-17 08:33:16, Michal Hocko wrote: On Sat 07-10-17 00:37:55, Yang Shi wrote: On 10/6/17 2:37 AM, Michal Hocko wrote: On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] + list_for_each_entry_safe(s, s2, _caches, list) { +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Yang Shi
On 10/8/17 11:36 PM, Michal Hocko wrote: On Mon 09-10-17 08:33:16, Michal Hocko wrote: On Sat 07-10-17 00:37:55, Yang Shi wrote: On 10/6/17 2:37 AM, Michal Hocko wrote: On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] + list_for_each_entry_safe(s, s2, _caches, list) { +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Michal Hocko
On Mon 09-10-17 08:33:16, Michal Hocko wrote: > On Sat 07-10-17 00:37:55, Yang Shi wrote: > > > > > > On 10/6/17 2:37 AM, Michal Hocko wrote: > > > On Thu 05-10-17 05:29:10, Yang Shi wrote: > [...] > > > > + list_for_each_entry_safe(s, s2, _caches, list) { > > > > + if

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Michal Hocko
On Mon 09-10-17 08:33:16, Michal Hocko wrote: > On Sat 07-10-17 00:37:55, Yang Shi wrote: > > > > > > On 10/6/17 2:37 AM, Michal Hocko wrote: > > > On Thu 05-10-17 05:29:10, Yang Shi wrote: > [...] > > > > + list_for_each_entry_safe(s, s2, _caches, list) { > > > > + if

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Michal Hocko
On Sat 07-10-17 00:37:55, Yang Shi wrote: > > > On 10/6/17 2:37 AM, Michal Hocko wrote: > > On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] > > > + list_for_each_entry_safe(s, s2, _caches, list) { > > > + if (!is_root_cache(s) || (s->flags & SLAB_RECLAIM_ACCOUNT)) > > > +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Michal Hocko
On Sat 07-10-17 00:37:55, Yang Shi wrote: > > > On 10/6/17 2:37 AM, Michal Hocko wrote: > > On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] > > > + list_for_each_entry_safe(s, s2, _caches, list) { > > > + if (!is_root_cache(s) || (s->flags & SLAB_RECLAIM_ACCOUNT)) > > > +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-07 Thread kbuild test robot
Hi Yang, [auto build test ERROR on mmotm/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-07 Thread kbuild test robot
Hi Yang, [auto build test ERROR on mmotm/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-07 Thread kbuild test robot
Hi Yang, [auto build test ERROR on mmotm/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-07 Thread kbuild test robot
Hi Yang, [auto build test ERROR on mmotm/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-06 Thread Yang Shi
On 10/6/17 2:37 AM, Michal Hocko wrote: On Thu 05-10-17 05:29:10, Yang Shi wrote: Kernel may panic when oom happens without killable process sometimes it is caused by huge unreclaimable slabs used by kernel. Although kdump could help debug such problem, however, kdump is not available on all

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-06 Thread Yang Shi
On 10/6/17 2:37 AM, Michal Hocko wrote: On Thu 05-10-17 05:29:10, Yang Shi wrote: Kernel may panic when oom happens without killable process sometimes it is caused by huge unreclaimable slabs used by kernel. Although kdump could help debug such problem, however, kdump is not available on all

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-06 Thread Michal Hocko
On Thu 05-10-17 05:29:10, Yang Shi wrote: > Kernel may panic when oom happens without killable process sometimes it > is caused by huge unreclaimable slabs used by kernel. > > Although kdump could help debug such problem, however, kdump is not > available on all architectures and it might be

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-06 Thread Michal Hocko
On Thu 05-10-17 05:29:10, Yang Shi wrote: > Kernel may panic when oom happens without killable process sometimes it > is caused by huge unreclaimable slabs used by kernel. > > Although kdump could help debug such problem, however, kdump is not > available on all architectures and it might be

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-05 Thread Michal Hocko
On Thu 05-10-17 02:08:48, Yang Shi wrote: > > > On 10/4/17 7:27 AM, Michal Hocko wrote: > > On Wed 04-10-17 02:06:17, Yang Shi wrote: > > > +static bool is_dump_unreclaim_slabs(void) > > > +{ > > > + unsigned long nr_lru; > > > + > > > + nr_lru = global_node_page_state(NR_ACTIVE_ANON) + > > > +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-05 Thread Michal Hocko
On Thu 05-10-17 02:08:48, Yang Shi wrote: > > > On 10/4/17 7:27 AM, Michal Hocko wrote: > > On Wed 04-10-17 02:06:17, Yang Shi wrote: > > > +static bool is_dump_unreclaim_slabs(void) > > > +{ > > > + unsigned long nr_lru; > > > + > > > + nr_lru = global_node_page_state(NR_ACTIVE_ANON) + > > > +

[PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-04 Thread Yang Shi
Kernel may panic when oom happens without killable process sometimes it is caused by huge unreclaimable slabs used by kernel. Although kdump could help debug such problem, however, kdump is not available on all architectures and it might be malfunction sometime. And, since kernel already panic it

[PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-04 Thread Yang Shi
Kernel may panic when oom happens without killable process sometimes it is caused by huge unreclaimable slabs used by kernel. Although kdump could help debug such problem, however, kdump is not available on all architectures and it might be malfunction sometime. And, since kernel already panic it

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-04 Thread Yang Shi
On 10/4/17 7:27 AM, Michal Hocko wrote: On Wed 04-10-17 02:06:17, Yang Shi wrote: +static bool is_dump_unreclaim_slabs(void) +{ + unsigned long nr_lru; + + nr_lru = global_node_page_state(NR_ACTIVE_ANON) + +global_node_page_state(NR_INACTIVE_ANON) + +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-04 Thread Yang Shi
On 10/4/17 7:27 AM, Michal Hocko wrote: On Wed 04-10-17 02:06:17, Yang Shi wrote: +static bool is_dump_unreclaim_slabs(void) +{ + unsigned long nr_lru; + + nr_lru = global_node_page_state(NR_ACTIVE_ANON) + +global_node_page_state(NR_INACTIVE_ANON) + +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-04 Thread Yang Shi
On 10/4/17 7:27 AM, Michal Hocko wrote: On Wed 04-10-17 02:06:17, Yang Shi wrote: +static bool is_dump_unreclaim_slabs(void) +{ + unsigned long nr_lru; + + nr_lru = global_node_page_state(NR_ACTIVE_ANON) + +global_node_page_state(NR_INACTIVE_ANON) + +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-04 Thread Yang Shi
On 10/4/17 7:27 AM, Michal Hocko wrote: On Wed 04-10-17 02:06:17, Yang Shi wrote: +static bool is_dump_unreclaim_slabs(void) +{ + unsigned long nr_lru; + + nr_lru = global_node_page_state(NR_ACTIVE_ANON) + +global_node_page_state(NR_INACTIVE_ANON) + +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-04 Thread Michal Hocko
On Wed 04-10-17 02:06:17, Yang Shi wrote: > +static bool is_dump_unreclaim_slabs(void) > +{ > + unsigned long nr_lru; > + > + nr_lru = global_node_page_state(NR_ACTIVE_ANON) + > + global_node_page_state(NR_INACTIVE_ANON) + > +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-04 Thread Michal Hocko
On Wed 04-10-17 02:06:17, Yang Shi wrote: > +static bool is_dump_unreclaim_slabs(void) > +{ > + unsigned long nr_lru; > + > + nr_lru = global_node_page_state(NR_ACTIVE_ANON) + > + global_node_page_state(NR_INACTIVE_ANON) + > +

[PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-03 Thread Yang Shi
Kernel may panic when oom happens without killable process sometimes it is caused by huge unreclaimable slabs used by kernel. Although kdump could help debug such problem, however, kdump is not available on all architectures and it might be malfunction sometime. And, since kernel already panic it

[PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-03 Thread Yang Shi
Kernel may panic when oom happens without killable process sometimes it is caused by huge unreclaimable slabs used by kernel. Although kdump could help debug such problem, however, kdump is not available on all architectures and it might be malfunction sometime. And, since kernel already panic it