On 05/22/2013 05:53 PM, Stephane Eranian wrote:
> Hi,
>
>
>
> On Wed, May 22, 2013 at 8:43 AM, Anshuman Khandual
> wrote:
>> On 05/21/2013 07:25 PM, Stephane Eranian wrote:
>>> On Thu, May 16, 2013 at 12:15 PM, Michael Neuling wrote:
Peter Zijlstra wrote:
> On Wed, May 15, 2013
Hi,
On Wed, May 22, 2013 at 8:43 AM, Anshuman Khandual
wrote:
> On 05/21/2013 07:25 PM, Stephane Eranian wrote:
>> On Thu, May 16, 2013 at 12:15 PM, Michael Neuling wrote:
>>> Peter Zijlstra wrote:
>>>
On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
> On Fri, May
On 05/21/2013 07:25 PM, Stephane Eranian wrote:
> On Thu, May 16, 2013 at 12:15 PM, Michael Neuling wrote:
>> Peter Zijlstra wrote:
>>
>>> On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra
wrote:
> We should always
On 05/21/2013 07:25 PM, Stephane Eranian wrote:
On Thu, May 16, 2013 at 12:15 PM, Michael Neuling mi...@neuling.org wrote:
Peter Zijlstra pet...@infradead.org wrote:
On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra
Hi,
On Wed, May 22, 2013 at 8:43 AM, Anshuman Khandual
khand...@linux.vnet.ibm.com wrote:
On 05/21/2013 07:25 PM, Stephane Eranian wrote:
On Thu, May 16, 2013 at 12:15 PM, Michael Neuling mi...@neuling.org wrote:
Peter Zijlstra pet...@infradead.org wrote:
On Wed, May 15, 2013 at 03:37:22PM
On 05/22/2013 05:53 PM, Stephane Eranian wrote:
Hi,
On Wed, May 22, 2013 at 8:43 AM, Anshuman Khandual
khand...@linux.vnet.ibm.com wrote:
On 05/21/2013 07:25 PM, Stephane Eranian wrote:
On Thu, May 16, 2013 at 12:15 PM, Michael Neuling mi...@neuling.org wrote:
Peter Zijlstra
On Thu, May 16, 2013 at 12:15 PM, Michael Neuling wrote:
> Peter Zijlstra wrote:
>
>> On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
>> > On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra
>> > wrote:
>> > > We should always have proper privileges when requesting kernel data.
>>
On Tue, May 21, 2013 at 10:50 AM, Peter Zijlstra wrote:
> On Tue, May 21, 2013 at 03:41:35PM +1000, Michael Neuling wrote:
>> Peter Zijlstra wrote:
>>
>> Can we add your signed-off-by on this?
>>
>> We are cleaning up our series for conditional branches and would like to
>> add this as part of
On Tue, May 21, 2013 at 03:41:35PM +1000, Michael Neuling wrote:
> Peter Zijlstra wrote:
>
> Can we add your signed-off-by on this?
>
> We are cleaning up our series for conditional branches and would like to
> add this as part of the post.
Sure, but its completely untested.. I was hoping
On Tue, May 21, 2013 at 03:41:35PM +1000, Michael Neuling wrote:
Peter Zijlstra pet...@infradead.org wrote:
Can we add your signed-off-by on this?
We are cleaning up our series for conditional branches and would like to
add this as part of the post.
Sure, but its completely untested.. I
On Tue, May 21, 2013 at 10:50 AM, Peter Zijlstra pet...@infradead.org wrote:
On Tue, May 21, 2013 at 03:41:35PM +1000, Michael Neuling wrote:
Peter Zijlstra pet...@infradead.org wrote:
Can we add your signed-off-by on this?
We are cleaning up our series for conditional branches and would
On Thu, May 16, 2013 at 12:15 PM, Michael Neuling mi...@neuling.org wrote:
Peter Zijlstra pet...@infradead.org wrote:
On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra a.p.zijls...@chello.nl
wrote:
We should always have
Peter Zijlstra wrote:
> On Thu, May 16, 2013 at 05:36:11PM +0200, Stephane Eranian wrote:
> > On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra
> > wrote:
> > > On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote:
> > >> Peter,
> > >>
> > >> BTW PowerPC also has the ability to filter
Peter Zijlstra pet...@infradead.org wrote:
On Thu, May 16, 2013 at 05:36:11PM +0200, Stephane Eranian wrote:
On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra pet...@infradead.org
wrote:
On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote:
Peter,
BTW PowerPC also has
On Sat, May 18, 2013 at 12:14 AM, Michael Neuling wrote:
> Stephane Eranian wrote:
>
>> On Fri, May 17, 2013 at 1:39 PM, Peter Zijlstra wrote:
>> > On Fri, May 17, 2013 at 09:32:08PM +1000, Michael Neuling wrote:
>> >> Peter Zijlstra wrote:
>> >
>> >> > Wouldn't it be mostly conditional
Stephane Eranian wrote:
> On Fri, May 17, 2013 at 1:39 PM, Peter Zijlstra wrote:
> > On Fri, May 17, 2013 at 09:32:08PM +1000, Michael Neuling wrote:
> >> Peter Zijlstra wrote:
> >
> >> > Wouldn't it be mostly conditional branches that are the primary control
> >> > flow
> >> > and can get
On Fri, May 17, 2013 at 1:39 PM, Peter Zijlstra wrote:
> On Fri, May 17, 2013 at 09:32:08PM +1000, Michael Neuling wrote:
>> Peter Zijlstra wrote:
>
>> > Wouldn't it be mostly conditional branches that are the primary control
>> > flow
>> > and can get predicted wrong? I mean, I'm sure someone
On Fri, May 17, 2013 at 09:32:08PM +1000, Michael Neuling wrote:
> Peter Zijlstra wrote:
> > Wouldn't it be mostly conditional branches that are the primary control flow
> > and can get predicted wrong? I mean, I'm sure someone will miss-predict an
> > unconditional branch but its not like we
Peter Zijlstra wrote:
> On Thu, May 16, 2013 at 05:36:11PM +0200, Stephane Eranian wrote:
> > On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra
> > wrote:
> > > On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote:
> > >> Peter,
> > >>
> > >> BTW PowerPC also has the ability to filter
On Thu, May 16, 2013 at 05:36:11PM +0200, Stephane Eranian wrote:
> On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra wrote:
> > On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote:
> >> Peter,
> >>
> >> BTW PowerPC also has the ability to filter on conditional branches. Any
> >>
On Thu, May 16, 2013 at 05:36:11PM +0200, Stephane Eranian wrote:
On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra pet...@infradead.org wrote:
On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote:
Peter,
BTW PowerPC also has the ability to filter on conditional branches. Any
Peter Zijlstra pet...@infradead.org wrote:
On Thu, May 16, 2013 at 05:36:11PM +0200, Stephane Eranian wrote:
On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra pet...@infradead.org
wrote:
On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote:
Peter,
BTW PowerPC also has
On Fri, May 17, 2013 at 09:32:08PM +1000, Michael Neuling wrote:
Peter Zijlstra pet...@infradead.org wrote:
Wouldn't it be mostly conditional branches that are the primary control flow
and can get predicted wrong? I mean, I'm sure someone will miss-predict an
unconditional branch but its
On Fri, May 17, 2013 at 1:39 PM, Peter Zijlstra pet...@infradead.org wrote:
On Fri, May 17, 2013 at 09:32:08PM +1000, Michael Neuling wrote:
Peter Zijlstra pet...@infradead.org wrote:
Wouldn't it be mostly conditional branches that are the primary control
flow
and can get predicted
Stephane Eranian eran...@google.com wrote:
On Fri, May 17, 2013 at 1:39 PM, Peter Zijlstra pet...@infradead.org wrote:
On Fri, May 17, 2013 at 09:32:08PM +1000, Michael Neuling wrote:
Peter Zijlstra pet...@infradead.org wrote:
Wouldn't it be mostly conditional branches that are the
On Sat, May 18, 2013 at 12:14 AM, Michael Neuling mi...@neuling.org wrote:
Stephane Eranian eran...@google.com wrote:
On Fri, May 17, 2013 at 1:39 PM, Peter Zijlstra pet...@infradead.org wrote:
On Fri, May 17, 2013 at 09:32:08PM +1000, Michael Neuling wrote:
Peter Zijlstra
On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra wrote:
> On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote:
>> Peter,
>>
>> BTW PowerPC also has the ability to filter on conditional branches. Any
>> chance we could add something like the follow to perf also?
>>
>
> I don't see an
On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote:
> Peter,
>
> BTW PowerPC also has the ability to filter on conditional branches. Any
> chance we could add something like the follow to perf also?
>
I don't see an immediate problem with that except that we on x86 need to
Peter Zijlstra wrote:
> On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
> > On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra
> > wrote:
> > > We should always have proper privileges when requesting kernel data.
> > >
> > > Cc: Andi Kleen
> > > Cc: eran...@google.com
> > >
Peter Zijlstra wrote:
> On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
> > On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra
> > wrote:
> > > We should always have proper privileges when requesting kernel data.
> > >
> > > Cc: Andi Kleen
> > > Cc: eran...@google.com
> > >
On Thu, May 16, 2013 at 11:09:16AM +0200, Peter Zijlstra wrote:
> How about something like the below? It also adds the branch flags Mikey wanted
> for PowerPC.
The asymmetry is unfortunate, but I think its more useful to have the from
kernel branch target than it is not to have it. This way you
On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
> On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra wrote:
> > We should always have proper privileges when requesting kernel data.
> >
> > Cc: Andi Kleen
> > Cc: eran...@google.com
> > Signed-off-by: Peter Zijlstra
> > Link:
On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra a.p.zijls...@chello.nl wrote:
We should always have proper privileges when requesting kernel data.
Cc: Andi Kleen a...@linux.intel.com
Cc: eran...@google.com
Signed-off-by:
On Thu, May 16, 2013 at 11:09:16AM +0200, Peter Zijlstra wrote:
How about something like the below? It also adds the branch flags Mikey wanted
for PowerPC.
The asymmetry is unfortunate, but I think its more useful to have the from
kernel branch target than it is not to have it. This way you at
Peter Zijlstra pet...@infradead.org wrote:
On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra a.p.zijls...@chello.nl
wrote:
We should always have proper privileges when requesting kernel data.
Cc: Andi Kleen
Peter Zijlstra pet...@infradead.org wrote:
On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra a.p.zijls...@chello.nl
wrote:
We should always have proper privileges when requesting kernel data.
Cc: Andi Kleen
On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote:
Peter,
BTW PowerPC also has the ability to filter on conditional branches. Any
chance we could add something like the follow to perf also?
I don't see an immediate problem with that except that we on x86 need to
implement
On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra pet...@infradead.org wrote:
On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote:
Peter,
BTW PowerPC also has the ability to filter on conditional branches. Any
chance we could add something like the follow to perf also?
I don't
On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
> On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra wrote:
> > We should always have proper privileges when requesting kernel data.
> >
> > Cc: Andi Kleen
> > Cc: eran...@google.com
> > Signed-off-by: Peter Zijlstra
> > Link:
On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra wrote:
> We should always have proper privileges when requesting kernel data.
>
> Cc: Andi Kleen
> Cc: eran...@google.com
> Signed-off-by: Peter Zijlstra
> Link: http://lkml.kernel.org/n/tip-v0x9ky3ahzr6nm3c6ilwr...@git.kernel.org
> ---
>
On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra a.p.zijls...@chello.nl wrote:
We should always have proper privileges when requesting kernel data.
Cc: Andi Kleen a...@linux.intel.com
Cc: eran...@google.com
Signed-off-by: Peter Zijlstra a.p.zijls...@chello.nl
Link:
On Wed, May 15, 2013 at 03:37:22PM +0200, Stephane Eranian wrote:
On Fri, May 3, 2013 at 2:11 PM, Peter Zijlstra a.p.zijls...@chello.nl wrote:
We should always have proper privileges when requesting kernel data.
Cc: Andi Kleen a...@linux.intel.com
Cc: eran...@google.com
Signed-off-by:
On Fri, May 03, 2013 at 02:11:25PM +0200, Peter Zijlstra wrote:
> We should always have proper privileges when requesting kernel data.
>
> Cc: Andi Kleen
Acked-by: Andi Kleen
> --- a/arch/x86/kernel/cpu/perf_event_intel_lbr.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_lbr.c
> @@ -318,8
We should always have proper privileges when requesting kernel data.
Cc: Andi Kleen
Cc: eran...@google.com
Signed-off-by: Peter Zijlstra
Link: http://lkml.kernel.org/n/tip-v0x9ky3ahzr6nm3c6ilwr...@git.kernel.org
---
arch/x86/kernel/cpu/perf_event_intel_lbr.c |5 -
1 file changed, 4
We should always have proper privileges when requesting kernel data.
Cc: Andi Kleen a...@linux.intel.com
Cc: eran...@google.com
Signed-off-by: Peter Zijlstra a.p.zijls...@chello.nl
Link: http://lkml.kernel.org/n/tip-v0x9ky3ahzr6nm3c6ilwr...@git.kernel.org
---
On Fri, May 03, 2013 at 02:11:25PM +0200, Peter Zijlstra wrote:
We should always have proper privileges when requesting kernel data.
Cc: Andi Kleen a...@linux.intel.com
Acked-by: Andi Kleen a...@linux.intel.com
--- a/arch/x86/kernel/cpu/perf_event_intel_lbr.c
+++
46 matches
Mail list logo
