Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-23 Thread Felipe Balbi
On Fri, Jan 23, 2015 at 10:12:41AM +0200, Heikki Krogerus wrote: > Hi, > > On Thu, Jan 22, 2015 at 02:49:25PM -0600, Felipe Balbi wrote: > > On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: > > > > > + /* Store initial eye diagram optimisation value */ > > > > > + ret =

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-23 Thread Felipe Balbi
On Fri, Jan 23, 2015 at 10:23:48AM +0200, Heikki Krogerus wrote: > On Thu, Jan 22, 2015 at 02:51:24PM -0600, Felipe Balbi wrote: > > On Wed, Jan 21, 2015 at 01:39:58PM +0200, Heikki Krogerus wrote: > > > Hi, > > > > > > On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: > > > > On

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-23 Thread Heikki Krogerus
On Thu, Jan 22, 2015 at 02:51:24PM -0600, Felipe Balbi wrote: > On Wed, Jan 21, 2015 at 01:39:58PM +0200, Heikki Krogerus wrote: > > Hi, > > > > On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: > > > On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: > > > > > diff

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-23 Thread Heikki Krogerus
Hi, On Thu, Jan 22, 2015 at 02:49:25PM -0600, Felipe Balbi wrote: > On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: > > > > + /* Store initial eye diagram optimisation value */ > > > > + ret = ulpi_read(ulpi, ULPI_EXT_VENDOR_SPECIFIC); > > > > > > do they *all* use

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-23 Thread Heikki Krogerus
On Thu, Jan 22, 2015 at 02:51:24PM -0600, Felipe Balbi wrote: On Wed, Jan 21, 2015 at 01:39:58PM +0200, Heikki Krogerus wrote: Hi, On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: diff --git

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-23 Thread Heikki Krogerus
Hi, On Thu, Jan 22, 2015 at 02:49:25PM -0600, Felipe Balbi wrote: On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: + /* Store initial eye diagram optimisation value */ + ret = ulpi_read(ulpi, ULPI_EXT_VENDOR_SPECIFIC); do they *all* use this register

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-23 Thread Felipe Balbi
On Fri, Jan 23, 2015 at 10:23:48AM +0200, Heikki Krogerus wrote: On Thu, Jan 22, 2015 at 02:51:24PM -0600, Felipe Balbi wrote: On Wed, Jan 21, 2015 at 01:39:58PM +0200, Heikki Krogerus wrote: Hi, On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: On Tue, Jan 20, 2015

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-23 Thread Felipe Balbi
On Fri, Jan 23, 2015 at 10:12:41AM +0200, Heikki Krogerus wrote: Hi, On Thu, Jan 22, 2015 at 02:49:25PM -0600, Felipe Balbi wrote: On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: + /* Store initial eye diagram optimisation value */ + ret = ulpi_read(ulpi,

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-22 Thread Felipe Balbi
On Wed, Jan 21, 2015 at 01:39:58PM +0200, Heikki Krogerus wrote: > Hi, > > On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: > > On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: > > > > diff --git a/drivers/phy/ulpi/tusb1210.c b/drivers/phy/ulpi/tusb1210.c > > > > new

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-22 Thread Felipe Balbi
Hi, On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: > > > TUSB1210 ULPI PHY has vendor specific register for eye > > > diagram tuning. On some platforms the system firmware has > > > set optimized value to it. In order to not loose the > > > optimized value, the driver stores it

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-22 Thread Felipe Balbi
Hi, On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: TUSB1210 ULPI PHY has vendor specific register for eye diagram tuning. On some platforms the system firmware has set optimized value to it. In order to not loose the optimized value, the driver stores it during probe

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-22 Thread Felipe Balbi
On Wed, Jan 21, 2015 at 01:39:58PM +0200, Heikki Krogerus wrote: Hi, On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: diff --git a/drivers/phy/ulpi/tusb1210.c b/drivers/phy/ulpi/tusb1210.c new file mode

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-21 Thread Heikki Krogerus
Hi, On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: > On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: > > > diff --git a/drivers/phy/ulpi/tusb1210.c b/drivers/phy/ulpi/tusb1210.c > > > new file mode 100644 > > > index 000..ac77f98 > > > --- /dev/null > > > +++

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-21 Thread Heikki Krogerus
On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: > Hi, > > On Tue, Jan 20, 2015 at 11:18:22AM +0200, Heikki Krogerus wrote: > > TUSB1210 ULPI PHY has vendor specific register for eye > > diagram tuning. On some platforms the system firmware has > > set optimized value to it. In order

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-21 Thread Heikki Krogerus
Hi, On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: diff --git a/drivers/phy/ulpi/tusb1210.c b/drivers/phy/ulpi/tusb1210.c new file mode 100644 index 000..ac77f98 --- /dev/null +++

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-21 Thread Heikki Krogerus
On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: Hi, On Tue, Jan 20, 2015 at 11:18:22AM +0200, Heikki Krogerus wrote: TUSB1210 ULPI PHY has vendor specific register for eye diagram tuning. On some platforms the system firmware has set optimized value to it. In order to not

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-20 Thread Felipe Balbi
Hi, On Tue, Jan 20, 2015 at 11:18:22AM +0200, Heikki Krogerus wrote: > TUSB1210 ULPI PHY has vendor specific register for eye > diagram tuning. On some platforms the system firmware has > set optimized value to it. In order to not loose the > optimized value, the driver stores it during probe and

[PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-20 Thread Heikki Krogerus
TUSB1210 ULPI PHY has vendor specific register for eye diagram tuning. On some platforms the system firmware has set optimized value to it. In order to not loose the optimized value, the driver stores it during probe and restores it every time the PHY is powered back on. Signed-off-by: Heikki

[PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-20 Thread Heikki Krogerus
TUSB1210 ULPI PHY has vendor specific register for eye diagram tuning. On some platforms the system firmware has set optimized value to it. In order to not loose the optimized value, the driver stores it during probe and restores it every time the PHY is powered back on. Signed-off-by: Heikki

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-20 Thread Felipe Balbi
Hi, On Tue, Jan 20, 2015 at 11:18:22AM +0200, Heikki Krogerus wrote: TUSB1210 ULPI PHY has vendor specific register for eye diagram tuning. On some platforms the system firmware has set optimized value to it. In order to not loose the optimized value, the driver stores it during probe and