Re: [PATCH 3/3] pinctrl: actions: Add interrupt support for OWL S900 SoC

2018-06-12 Thread Linus Walleij
On Sat, Jun 2, 2018 at 6:54 PM, Manivannan Sadhasivam wrote: > Add interrupt support for Actions Semi OWL S900 SoC. > > Signed-off-by: Manivannan Sadhasivam (...) > +++ b/drivers/pinctrl/actions/Kconfig > @@ -5,6 +5,7 @@ config PINCTRL_OWL > select PINCONF > select GENERIC_PINCO

Re: [PATCH 3/3] pinctrl: actions: Add interrupt support for OWL S900 SoC

2018-06-03 Thread Manivannan Sadhasivam
Hi Andy, On Sun, Jun 03, 2018 at 11:37:53AM +0300, Andy Shevchenko wrote: > On Sat, Jun 2, 2018 at 7:54 PM, Manivannan Sadhasivam > wrote: > > Add interrupt support for Actions Semi OWL S900 SoC. > > > + port = owl_gpio_get_port(pctrl, &gpio); > > + if (WARN_ON(port == NULL)) > > +

Re: [PATCH 3/3] pinctrl: actions: Add interrupt support for OWL S900 SoC

2018-06-03 Thread Andy Shevchenko
On Sat, Jun 2, 2018 at 7:54 PM, Manivannan Sadhasivam wrote: > Add interrupt support for Actions Semi OWL S900 SoC. > + port = owl_gpio_get_port(pctrl, &gpio); > + if (WARN_ON(port == NULL)) > + return; At which circumstances the above possible? > + port = owl_gp

[PATCH 3/3] pinctrl: actions: Add interrupt support for OWL S900 SoC

2018-06-02 Thread Manivannan Sadhasivam
Add interrupt support for Actions Semi OWL S900 SoC. Signed-off-by: Manivannan Sadhasivam --- drivers/pinctrl/actions/Kconfig| 1 + drivers/pinctrl/actions/pinctrl-owl.c | 231 - drivers/pinctrl/actions/pinctrl-owl.h | 22 ++- drivers/pinctrl/actions/pinctrl-