Re: [PATCH 3/3] printk: move CONSOLE_EXT_LOG_MAX to kernel/printk/printk.c

2021-02-03 Thread Petr Mladek
On Tue 2021-02-02 20:29:31, kernel test robot wrote: > Hi Masahiro, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linux/master] > [also build test ERROR on efi/next tty/tty-testing tip/x86/core v5.11-rc6 > next-20210125] > [cannot apply to pmladek/for-next] > [If

Re: [PATCH 3/3] printk: move CONSOLE_EXT_LOG_MAX to kernel/printk/printk.c

2021-02-02 Thread kernel test robot
Hi Masahiro, I love your patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on efi/next tty/tty-testing tip/x86/core v5.11-rc6 next-20210125] [cannot apply to pmladek/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. An

Re: [PATCH 3/3] printk: move CONSOLE_EXT_LOG_MAX to kernel/printk/printk.c

2021-02-02 Thread Sergey Senozhatsky
On (21/02/02 09:50), John Ogness wrote: > > The only consequences could be out-of-tree modules breaking, > but do we care about that? Yeah, I don't think anyone does. So we are fine here. -ss

Re: [PATCH 3/3] printk: move CONSOLE_EXT_LOG_MAX to kernel/printk/printk.c

2021-02-02 Thread John Ogness
On 2021-02-02, Masahiro Yamada wrote: > This macro is only used in kernel/printk/printk.c I recently posted a patch [0] that added another macro CONSOLE_LOG_MAX here. But it also is only used in printk.c. I see no reason why either should be in the header. Neither my patch nor commit d43ff430f434

[PATCH 3/3] printk: move CONSOLE_EXT_LOG_MAX to kernel/printk/printk.c

2021-02-01 Thread Masahiro Yamada
This macro is only used in kernel/printk/printk.c Signed-off-by: Masahiro Yamada --- include/linux/printk.h | 2 -- kernel/printk/printk.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index ceaf0486c01c..d2c9c2a6e471 1006