Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver

2019-08-12 Thread Rob Herring
On Mon, Jul 22, 2019 at 02:48:40PM -0700, Paul Walmsley wrote: > On Fri, 19 Jul 2019, Yash Shah wrote: > > > DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added > > > > Signed-off-by: Yash Shah > > Thanks, queuing this one for v5.3-rc with Andrew's suggested change to >

Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver

2019-07-22 Thread Paul Walmsley
On Fri, 19 Jul 2019, Yash Shah wrote: > DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added > > Signed-off-by: Yash Shah Thanks, queuing this one for v5.3-rc with Andrew's suggested change to change phy1 to phy0. Am assuming patches 1 and 2 will go in via -net. - Paul

Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver

2019-07-22 Thread Sagar Kadam
Hello Andrew, On Fri, Jul 19, 2019 at 6:57 PM Andrew Lunn wrote: > > On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote: > > > + { > > > + status = "okay"; > > > + phy-mode = "gmii"; > > > + phy-handle = <>; > > > + phy1: ethernet-phy@0 { > > > +

Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver

2019-07-19 Thread Andrew Lunn
On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote: > > + { > > + status = "okay"; > > + phy-mode = "gmii"; > > + phy-handle = <>; > > + phy1: ethernet-phy@0 { > > + reg = <0>; > > + }; Hi Sagar Is there a good reason to call it phy1? Is there

Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver

2019-07-19 Thread Sagar Kadam
The series looks good to me. Reviewed-by: Sagar Kadam On Fri, Jul 19, 2019 at 4:41 PM Yash Shah wrote: > > DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added > > Signed-off-by: Yash Shah > --- > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 15 +++ >

[PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver

2019-07-19 Thread Yash Shah
DT node for SiFive FU540-C000 GEMGXL Ethernet controller driver added Signed-off-by: Yash Shah --- arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 15 +++ arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 9 + 2 files changed, 24 insertions(+) diff --git