Re: [PATCH 3/3] staging: iio: ad7780: generates pattern_mask from PAT bits

2018-11-07 Thread Ardelean, Alexandru
On Wed, 2018-11-07 at 16:50 -0200, Giuliano Belinassi wrote: > Previously, all pattern_masks in the chip_info table were hardcoded. Now > they > are generated using the PAT macros, as described in the datasheets. > I like this change :) I only have nitpicks. See inline. > Signed-off-by:

Re: [PATCH 3/3] staging: iio: ad7780: generates pattern_mask from PAT bits

2018-11-07 Thread Ardelean, Alexandru
On Wed, 2018-11-07 at 16:50 -0200, Giuliano Belinassi wrote: > Previously, all pattern_masks in the chip_info table were hardcoded. Now > they > are generated using the PAT macros, as described in the datasheets. > I like this change :) I only have nitpicks. See inline. > Signed-off-by:

[PATCH 3/3] staging: iio: ad7780: generates pattern_mask from PAT bits

2018-11-07 Thread Giuliano Belinassi
Previously, all pattern_masks in the chip_info table were hardcoded. Now they are generated using the PAT macros, as described in the datasheets. Signed-off-by: Giuliano Belinassi --- drivers/staging/iio/adc/ad7780.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH 3/3] staging: iio: ad7780: generates pattern_mask from PAT bits

2018-11-07 Thread Giuliano Belinassi
Previously, all pattern_masks in the chip_info table were hardcoded. Now they are generated using the PAT macros, as described in the datasheets. Signed-off-by: Giuliano Belinassi --- drivers/staging/iio/adc/ad7780.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git