Re: [PATCH 3/3] statx: add STATX_ATTRIBUTES flag

2018-10-18 Thread Andreas Dilger
On Oct 18, 2018, at 7:11 AM, Miklos Szeredi wrote: > > FUSE will want to know if stx_attributes is interesting or not, because > there's a non-zero cost of retreiving it. > > This is more of a "want" flag, since stx_attributes_mask already indicates > whether we "got" stx_attributes or not. So

Re: [PATCH 3/3] statx: add STATX_ATTRIBUTES flag

2018-10-18 Thread Andreas Dilger
On Oct 18, 2018, at 7:11 AM, Miklos Szeredi wrote: > > FUSE will want to know if stx_attributes is interesting or not, because > there's a non-zero cost of retreiving it. > > This is more of a "want" flag, since stx_attributes_mask already indicates > whether we "got" stx_attributes or not. So

Re: [PATCH 3/3] statx: add STATX_ATTRIBUTES flag

2018-10-18 Thread David Howells
Miklos Szeredi wrote: > + /* Having anything in attributes_mask means attributes are valid. */ > + if (tmp.stx_attributes_mask) > + tmp.stx_mask |= STATX_ATTRIBUTES; That would be superfluous, since userspace can make this check too. Note that fsinfo() might inform you

Re: [PATCH 3/3] statx: add STATX_ATTRIBUTES flag

2018-10-18 Thread David Howells
Miklos Szeredi wrote: > + /* Having anything in attributes_mask means attributes are valid. */ > + if (tmp.stx_attributes_mask) > + tmp.stx_mask |= STATX_ATTRIBUTES; That would be superfluous, since userspace can make this check too. Note that fsinfo() might inform you

[PATCH 3/3] statx: add STATX_ATTRIBUTES flag

2018-10-18 Thread Miklos Szeredi
FUSE will want to know if stx_attributes is interesting or not, because there's a non-zero cost of retreiving it. This is more of a "want" flag, since stx_attributes_mask already indicates whether we "got" stx_attributes or not. So for now we can just deal with this flag in the generic code.

[PATCH 3/3] statx: add STATX_ATTRIBUTES flag

2018-10-18 Thread Miklos Szeredi
FUSE will want to know if stx_attributes is interesting or not, because there's a non-zero cost of retreiving it. This is more of a "want" flag, since stx_attributes_mask already indicates whether we "got" stx_attributes or not. So for now we can just deal with this flag in the generic code.