Re: [PATCH 3/3] task: Clean house now that tasks on the runqueue are rcu protected

2019-09-03 Thread Oleg Nesterov
On 09/02, Eric W. Biederman wrote: > > @@ -1644,7 +1644,7 @@ static void task_numa_compare(struct task_numa_env *env, > return; > > rcu_read_lock(); > - cur = task_rcu_dereference(_rq->curr); > + cur = rcu_dereference(dst_rq->curr); > if (cur && ((cur->flags &

Re: [PATCH 3/3] task: Clean house now that tasks on the runqueue are rcu protected

2019-09-03 Thread kbuild test robot
Hi "Eric, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3-rc7 next-20190902] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 3/3] task: Clean house now that tasks on the runqueue are rcu protected

2019-09-02 Thread Eric W. Biederman
Use rcu_dereference instead of task_rcu_dereference. Remove task_rcu_dereference. Remove the complications of rcuwait that were in place because tasks on the runqueue were not rcu protected. It is now safe to call wake_up_process if the target was know to be on the runqueue in the current rcu