Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-04-03 Thread Sascha Hauer
On Wed, Apr 03, 2013 at 08:30:00AM -0700, Guenter Roeck wrote: > On Wed, Apr 03, 2013 at 05:09:52PM +0200, Sascha Hauer wrote: > [ ... ] > > > > > > > On a side note, if the driver supports devicetree, it might make sense to > > > call > > > watchdog_init_timeout, since it initializes the

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-04-03 Thread Guenter Roeck
On Wed, Apr 03, 2013 at 05:09:52PM +0200, Sascha Hauer wrote: [ ... ] > > > > On a side note, if the driver supports devicetree, it might make sense to > > call > > watchdog_init_timeout, since it initializes the timeout from devicetree > > data. > > The driver does not support devicetree. >

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-04-03 Thread Sascha Hauer
On Tue, Mar 26, 2013 at 07:33:31AM -0700, Guenter Roeck wrote: > On Tue, Mar 26, 2013 at 11:16:35AM +0100, Christian Gmeiner wrote: > > 2013/2/12 Sascha Hauer : > > > This driver provides support for the CGEB watchdog found on some > > > Congatec x86 modules. > > > > > > Signed-off-by: Sascha

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-04-03 Thread Sascha Hauer
On Tue, Mar 26, 2013 at 11:16:35AM +0100, Christian Gmeiner wrote: > 2013/2/12 Sascha Hauer : > > -- > > There seems to be a problem: > > Mar 26 16:11:25 OT kernel: [ 80.207514] cgeb-watchdog > cgeb-watchdog.0: registered > Mar 26 16:11:38 OT watchdog[2519]: stopping daemon (5.9) > Mar 26

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-04-03 Thread Sascha Hauer
On Tue, Mar 26, 2013 at 11:16:35AM +0100, Christian Gmeiner wrote: 2013/2/12 Sascha Hauer s.ha...@pengutronix.de: -- There seems to be a problem: Mar 26 16:11:25 OT kernel: [ 80.207514] cgeb-watchdog cgeb-watchdog.0: registered Mar 26 16:11:38 OT watchdog[2519]: stopping daemon (5.9)

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-04-03 Thread Sascha Hauer
On Tue, Mar 26, 2013 at 07:33:31AM -0700, Guenter Roeck wrote: On Tue, Mar 26, 2013 at 11:16:35AM +0100, Christian Gmeiner wrote: 2013/2/12 Sascha Hauer s.ha...@pengutronix.de: This driver provides support for the CGEB watchdog found on some Congatec x86 modules. Signed-off-by:

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-04-03 Thread Guenter Roeck
On Wed, Apr 03, 2013 at 05:09:52PM +0200, Sascha Hauer wrote: [ ... ] On a side note, if the driver supports devicetree, it might make sense to call watchdog_init_timeout, since it initializes the timeout from devicetree data. The driver does not support devicetree. I should

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-04-03 Thread Sascha Hauer
On Wed, Apr 03, 2013 at 08:30:00AM -0700, Guenter Roeck wrote: On Wed, Apr 03, 2013 at 05:09:52PM +0200, Sascha Hauer wrote: [ ... ] On a side note, if the driver supports devicetree, it might make sense to call watchdog_init_timeout, since it initializes the timeout from

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-03-26 Thread Guenter Roeck
On Tue, Mar 26, 2013 at 11:16:35AM +0100, Christian Gmeiner wrote: > 2013/2/12 Sascha Hauer : > > This driver provides support for the CGEB watchdog found on some > > Congatec x86 modules. > > > > Signed-off-by: Sascha Hauer > > --- > > drivers/watchdog/Kconfig | 10 ++ > >

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-03-26 Thread Christian Gmeiner
2013/2/12 Sascha Hauer : > This driver provides support for the CGEB watchdog found on some > Congatec x86 modules. > > Signed-off-by: Sascha Hauer > --- > drivers/watchdog/Kconfig | 10 ++ > drivers/watchdog/Makefile |1 + >

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-03-26 Thread Christian Gmeiner
2013/2/12 Sascha Hauer s.ha...@pengutronix.de: This driver provides support for the CGEB watchdog found on some Congatec x86 modules. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/watchdog/Kconfig | 10 ++ drivers/watchdog/Makefile |1

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-03-26 Thread Guenter Roeck
On Tue, Mar 26, 2013 at 11:16:35AM +0100, Christian Gmeiner wrote: 2013/2/12 Sascha Hauer s.ha...@pengutronix.de: This driver provides support for the CGEB watchdog found on some Congatec x86 modules. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/watchdog/Kconfig

[PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-02-12 Thread Sascha Hauer
This driver provides support for the CGEB watchdog found on some Congatec x86 modules. Signed-off-by: Sascha Hauer --- drivers/watchdog/Kconfig | 10 ++ drivers/watchdog/Makefile |1 + drivers/watchdog/congatec_cgeb_watchdog.c | 161

[PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-02-12 Thread Sascha Hauer
This driver provides support for the CGEB watchdog found on some Congatec x86 modules. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/watchdog/Kconfig | 10 ++ drivers/watchdog/Makefile |1 + drivers/watchdog/congatec_cgeb_watchdog.c | 161