Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-22 Thread Viresh Kumar
On 22 March 2013 13:33, Stratos Karafotis wrote: > Use an inline function to evaluate freq_target to avoid duplicate code. > > Also, define a macro for the default frequency step. > > Signed-off-by: Stratos Karafotis > --- > drivers/cpufreq/cpufreq_conservative.c | 28

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-22 Thread Stratos Karafotis
Hi Rafael, On 03/22/2013 01:51 AM, Rafael J. Wysocki wrote: > This one didn't apply for me to linux-pm.git/bleeding-edge. Care to rebase? > > Rafael Yes, of course. Bellow the rebased patched against latest linux-pm.git/bleeding-edge. Thanks, Stratos

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-22 Thread Stratos Karafotis
Hi Rafael, On 03/22/2013 01:51 AM, Rafael J. Wysocki wrote: This one didn't apply for me to linux-pm.git/bleeding-edge. Care to rebase? Rafael Yes, of course. Bellow the rebased patched against latest linux-pm.git/bleeding-edge. Thanks, Stratos

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-22 Thread Viresh Kumar
On 22 March 2013 13:33, Stratos Karafotis strat...@semaphore.gr wrote: Use an inline function to evaluate freq_target to avoid duplicate code. Also, define a macro for the default frequency step. Signed-off-by: Stratos Karafotis strat...@semaphore.gr ---

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-21 Thread Rafael J. Wysocki
On Wednesday, March 06, 2013 04:15:41 PM Stratos Karafotis wrote: > On 03/06/2013 03:23 PM, Viresh Kumar wrote: > > Atleast my poor mind can't make out how. To me it looks like broken now. > > > > > > When can we enter this "if" block, probably only in case where max freq is > > less than 100

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-21 Thread Rafael J. Wysocki
On Wednesday, March 06, 2013 04:15:41 PM Stratos Karafotis wrote: On 03/06/2013 03:23 PM, Viresh Kumar wrote: Atleast my poor mind can't make out how. To me it looks like broken now. When can we enter this if block, probably only in case where max freq is less than 100 KHz (And

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-11 Thread Stratos Karafotis
> On 6 March 2013 22:15, Stratos Karafotis wrote: >> Use an inline function to evaluate freq_target to avoid duplicate code. >> >> Also, define a macro for the default frequency step. >> >> Signed-off-by: Stratos Karafotis >> --- >> drivers/cpufreq/cpufreq_conservative.c | 27

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-11 Thread Stratos Karafotis
On 6 March 2013 22:15, Stratos Karafotis strat...@semaphore.gr wrote: Use an inline function to evaluate freq_target to avoid duplicate code. Also, define a macro for the default frequency step. Signed-off-by: Stratos Karafotis strat...@semaphore.gr ---

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-06 Thread Viresh Kumar
On 6 March 2013 22:15, Stratos Karafotis wrote: > Use an inline function to evaluate freq_target to avoid duplicate code. > > Also, define a macro for the default frequency step. > > Signed-off-by: Stratos Karafotis > --- > drivers/cpufreq/cpufreq_conservative.c | 27 +++

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-06 Thread Stratos Karafotis
On 03/06/2013 03:23 PM, Viresh Kumar wrote: > Atleast my poor mind can't make out how. To me it looks like broken now. > > > When can we enter this "if" block, probably only in case where max freq is > less than 100 KHz (And because we have freq unit in KHz in cpufreq, its exact > value is less

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-06 Thread Viresh Kumar
On 6 March 2013 06:06, Stratos Karafotis wrote: > Use an inline function to evaluate freq_target to avoid duplicate code. > > Also, define a macro for the default frequency step and fix the > calculation of freq_target when the max freq is less that 100. s/that/than :) -- To unsubscribe from

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-06 Thread Viresh Kumar
On 6 March 2013 06:06, Stratos Karafotis wrote: > Use an inline function to evaluate freq_target to avoid duplicate code. > > Also, define a macro for the default frequency step and fix the > calculation of freq_target when the max freq is less that 100. Atleast my poor mind can't make out how.

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-06 Thread Viresh Kumar
On 6 March 2013 06:06, Stratos Karafotis strat...@semaphore.gr wrote: Use an inline function to evaluate freq_target to avoid duplicate code. Also, define a macro for the default frequency step and fix the calculation of freq_target when the max freq is less that 100. Atleast my poor mind

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-06 Thread Viresh Kumar
On 6 March 2013 06:06, Stratos Karafotis strat...@semaphore.gr wrote: Use an inline function to evaluate freq_target to avoid duplicate code. Also, define a macro for the default frequency step and fix the calculation of freq_target when the max freq is less that 100. s/that/than :) -- To

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-06 Thread Stratos Karafotis
On 03/06/2013 03:23 PM, Viresh Kumar wrote: Atleast my poor mind can't make out how. To me it looks like broken now. When can we enter this if block, probably only in case where max freq is less than 100 KHz (And because we have freq unit in KHz in cpufreq, its exact value is less than

Re: [PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-06 Thread Viresh Kumar
On 6 March 2013 22:15, Stratos Karafotis strat...@semaphore.gr wrote: Use an inline function to evaluate freq_target to avoid duplicate code. Also, define a macro for the default frequency step. Signed-off-by: Stratos Karafotis strat...@semaphore.gr ---

[PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-05 Thread Stratos Karafotis
Use an inline function to evaluate freq_target to avoid duplicate code. Also, define a macro for the default frequency step and fix the calculation of freq_target when the max freq is less that 100. Signed-off-by: Stratos Karafotis --- drivers/cpufreq/cpufreq_conservative.c | 27

[PATCH 3/3 linux-next] cpufreq: conservative: Use an inline function to evaluate freq_target

2013-03-05 Thread Stratos Karafotis
Use an inline function to evaluate freq_target to avoid duplicate code. Also, define a macro for the default frequency step and fix the calculation of freq_target when the max freq is less that 100. Signed-off-by: Stratos Karafotis strat...@semaphore.gr ---