Re: [PATCH 3/4] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

2015-02-17 Thread Roger Quadros
On 17/02/15 15:48, Robert Abel wrote: > Hi Roger, > > On Tue, Feb 17, 2015 at 10:27 AM, Roger Quadros wrote: >> >> Can you please point out which DT had used this pre-divided workaround? We >> will have to >> fix those then. > > I didn't check. A cursory glance reveals all DTS in arch/arm/boot/

Re: [PATCH 3/4] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

2015-02-17 Thread Robert Abel
Hi Roger, On Tue, Feb 17, 2015 at 10:27 AM, Roger Quadros wrote: > > Can you please point out which DT had used this pre-divided workaround? We > will have to > fix those then. I didn't check. A cursory glance reveals all DTS in arch/arm/boot/dts to use a value of 0. > > Can you please rebase

Re: [PATCH 3/4] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

2015-02-17 Thread Roger Quadros
Robert, On 16/02/15 17:49, Robert ABEL wrote: > WAITMONITORINGTIME is expressed in GPMC_CLK cycles (even for asynchronous > accesses). > However the driver currently converts them to GPMC_FCLK cycles, thus > waitmonitoringtime in dt > had to be predivided by divider as a workaround. This patch f

[PATCH 3/4] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

2015-02-16 Thread Robert ABEL
WAITMONITORINGTIME is expressed in GPMC_CLK cycles (even for asynchronous accesses). However the driver currently converts them to GPMC_FCLK cycles, thus waitmonitoringtime in dt had to be predivided by divider as a workaround. This patch fixes the issue by reading the current GPMCFCLKDIVIDER an