On Thursday, March 20, 2014 01:57:10 PM Bartlomiej Zolnierkiewicz wrote:
> > > +#define DA8XX_SYSCFG1_VIRT(x)(da8xx_syscfg1_base + (x))
> > > +#define DA8XX_PWRDN_REG 0x18
> > > +
> > > +/* SATA PHY Control Register offset from AHCI base */
> > > +#define SATA_P0PHYCR_REG 0x178
> > >
On Thursday, March 20, 2014 06:53:09 PM Sekhar Nori wrote:
> On Thursday 20 March 2014 06:27 PM, Bartlomiej Zolnierkiewicz wrote:
>
> >>> diff --git a/drivers/ata/ahci_da850.c b/drivers/ata/ahci_da850.c
>
> >>> +extern void __iomem *da8xx_syscfg1_base;
> >>
> >> This platform specific extern
On Thursday 20 March 2014 06:27 PM, Bartlomiej Zolnierkiewicz wrote:
>>> diff --git a/drivers/ata/ahci_da850.c b/drivers/ata/ahci_da850.c
>>> +extern void __iomem *da8xx_syscfg1_base;
>>
>> This platform specific extern symbol should not be used in drivers and
>> in fact checkpatch complains
Hi,
On Thursday, March 20, 2014 01:41:28 PM Sekhar Nori wrote:
> Hi Bartlomiej,
>
> On Tuesday 18 March 2014 12:01 AM, Bartlomiej Zolnierkiewicz wrote:
> > The new driver is named ahci_da850 and is only compile tested. Once it
> > is tested on the real hardware and verified to work correctly,
Hi Bartlomiej,
On Tuesday 18 March 2014 12:01 AM, Bartlomiej Zolnierkiewicz wrote:
> The new driver is named ahci_da850 and is only compile tested. Once it
> is tested on the real hardware and verified to work correctly, the legacy
> platform code (which depends on the deprecated struct
Hi Bartlomiej,
On Tuesday 18 March 2014 12:01 AM, Bartlomiej Zolnierkiewicz wrote:
The new driver is named ahci_da850 and is only compile tested. Once it
is tested on the real hardware and verified to work correctly, the legacy
platform code (which depends on the deprecated struct
Hi,
On Thursday, March 20, 2014 01:41:28 PM Sekhar Nori wrote:
Hi Bartlomiej,
On Tuesday 18 March 2014 12:01 AM, Bartlomiej Zolnierkiewicz wrote:
The new driver is named ahci_da850 and is only compile tested. Once it
is tested on the real hardware and verified to work correctly, the
On Thursday 20 March 2014 06:27 PM, Bartlomiej Zolnierkiewicz wrote:
diff --git a/drivers/ata/ahci_da850.c b/drivers/ata/ahci_da850.c
+extern void __iomem *da8xx_syscfg1_base;
This platform specific extern symbol should not be used in drivers and
in fact checkpatch complains about it too.
On Thursday, March 20, 2014 06:53:09 PM Sekhar Nori wrote:
On Thursday 20 March 2014 06:27 PM, Bartlomiej Zolnierkiewicz wrote:
diff --git a/drivers/ata/ahci_da850.c b/drivers/ata/ahci_da850.c
+extern void __iomem *da8xx_syscfg1_base;
This platform specific extern symbol should not be
On Thursday, March 20, 2014 01:57:10 PM Bartlomiej Zolnierkiewicz wrote:
+#define DA8XX_SYSCFG1_VIRT(x)(da8xx_syscfg1_base + (x))
+#define DA8XX_PWRDN_REG 0x18
+
+/* SATA PHY Control Register offset from AHCI base */
+#define SATA_P0PHYCR_REG 0x178
+
+#define
The new driver is named ahci_da850 and is only compile tested. Once it
is tested on the real hardware and verified to work correctly, the legacy
platform code (which depends on the deprecated struct ahci_platform_data)
can be removed.
Signed-off-by: Bartlomiej Zolnierkiewicz
---
The new driver is named ahci_da850 and is only compile tested. Once it
is tested on the real hardware and verified to work correctly, the legacy
platform code (which depends on the deprecated struct ahci_platform_data)
can be removed.
Signed-off-by: Bartlomiej Zolnierkiewicz
12 matches
Mail list logo
