Arjan, thank you very much for reviewing the driver.
Arjan van de Ven wrote:
On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote:
[snip]
+void atl1_irq_disable(struct atl1_adapter *adapter)
+{
+ atomic_inc(>irq_sem);
+ iowrite32(0, adapter->hw.hw_addr + REG_IMR);
+
On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote:
> +
> + /* PCI config space info */
> + pci_read_config_byte(pdev, PCI_REVISION_ID, >revision_id);
> + pci_read_config_word(pdev, PCI_COMMAND, >pci_cmd_word);
I'm highly suspicious of drivers that use the PCI_COMMAND word...
On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote:
+
+ /* PCI config space info */
+ pci_read_config_byte(pdev, PCI_REVISION_ID, hw-revision_id);
+ pci_read_config_word(pdev, PCI_COMMAND, hw-pci_cmd_word);
I'm highly suspicious of drivers that use the PCI_COMMAND word...
Arjan, thank you very much for reviewing the driver.
Arjan van de Ven wrote:
On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote:
[snip]
+void atl1_irq_disable(struct atl1_adapter *adapter)
+{
+ atomic_inc(adapter-irq_sem);
+ iowrite32(0, adapter-hw.hw_addr + REG_IMR);
+
> +#include
Why do you need this one?
> +#include
Shouldn't be needed aswell.
> +#include
, please.
> + spin_lock_init(>stats_lock);
> + spin_lock_init(>tx_lock);
> + spin_lock_init(>mb_lock);
> + spin_lock_init(>vl_lock);
> + spin_lock_init(>mii_lock);
Do you really
+#include asm/page.h
Why do you need this one?
+#include asm/system.h
Shouldn't be needed aswell.
+#include asm/checksum.h
net/checksum.h, please.
+ spin_lock_init(adapter-stats_lock);
+ spin_lock_init(adapter-tx_lock);
+ spin_lock_init(adapter-mb_lock);
+
On Sunday 19 November 2006 21:30, Jay Cliburn wrote:
> This patch contains the main C file for the Attansic L1 gigabit ethernet
> adapter driver.
Just a few style comments:
> + /* PCI config space info */
> + hw->vendor_id = pdev->vendor;
> + hw->device_id = pdev->device;
> +
>+char at_driver_name[] = "atl1";
>+static const char at_driver_string[] = "Attansic(R) L1 Ethernet Network
>Driver";
>+const char at_driver_version[] = DRV_VERSION;
>+static const char at_copyright[] =
>+"Copyright(c) 2005-2006 Attansic Corporation.";
>+
>+extern s32 at_read_mac_addr(struct
+char at_driver_name[] = atl1;
+static const char at_driver_string[] = Attansic(R) L1 Ethernet Network
Driver;
+const char at_driver_version[] = DRV_VERSION;
+static const char at_copyright[] =
+Copyright(c) 2005-2006 Attansic Corporation.;
+
+extern s32 at_read_mac_addr(struct at_hw *hw);
On Sunday 19 November 2006 21:30, Jay Cliburn wrote:
This patch contains the main C file for the Attansic L1 gigabit ethernet
adapter driver.
Just a few style comments:
+ /* PCI config space info */
+ hw-vendor_id = pdev-vendor;
+ hw-device_id = pdev-device;
+
10 matches
Mail list logo
