Re: [PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-04-11 Thread Jens Axboe
On 04/11/2014 01:33 AM, Christoph Hellwig wrote: On Thu, Apr 10, 2014 at 08:42:27PM -0600, Jens Axboe wrote: Great. Will you send out an updated patchset? I was waiting for you to apply the previous series, but I'll just resend my whole set of outstanding patches, it'll need a bit of rebasing

Re: [PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-04-11 Thread Christoph Hellwig
On Thu, Apr 10, 2014 at 08:42:27PM -0600, Jens Axboe wrote: > Great. Will you send out an updated patchset? I was waiting for you to apply the previous series, but I'll just resend my whole set of outstanding patches, it'll need a bit of rebasing against your updated tree anyway. -- To

Re: [PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-04-11 Thread Christoph Hellwig
On Thu, Apr 10, 2014 at 08:42:27PM -0600, Jens Axboe wrote: Great. Will you send out an updated patchset? I was waiting for you to apply the previous series, but I'll just resend my whole set of outstanding patches, it'll need a bit of rebasing against your updated tree anyway. -- To

Re: [PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-04-11 Thread Jens Axboe
On 04/11/2014 01:33 AM, Christoph Hellwig wrote: On Thu, Apr 10, 2014 at 08:42:27PM -0600, Jens Axboe wrote: Great. Will you send out an updated patchset? I was waiting for you to apply the previous series, but I'll just resend my whole set of outstanding patches, it'll need a bit of rebasing

Re: [PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-04-10 Thread Jens Axboe
On 2014-04-10 04:01, Christoph Hellwig wrote: On Wed, Apr 09, 2014 at 10:23:32AM -0600, Jens Axboe wrote: This should go into block/blk-mq-tag.h. Ok. We might as well leave this, the mtip32xx conversion ends up using it. So if we pull it now, it'll just be reintroduced shortly. It's back

Re: [PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-04-10 Thread Christoph Hellwig
On Wed, Apr 09, 2014 at 10:23:32AM -0600, Jens Axboe wrote: > This should go into block/blk-mq-tag.h. Ok. > We might as well leave this, the mtip32xx conversion ends up using it. So > if we pull it now, it'll just be reintroduced shortly. It's back in the latest revision of the patch, just

Re: [PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-04-10 Thread Christoph Hellwig
On Wed, Apr 09, 2014 at 10:23:32AM -0600, Jens Axboe wrote: This should go into block/blk-mq-tag.h. Ok. We might as well leave this, the mtip32xx conversion ends up using it. So if we pull it now, it'll just be reintroduced shortly. It's back in the latest revision of the patch, just taking

Re: [PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-04-10 Thread Jens Axboe
On 2014-04-10 04:01, Christoph Hellwig wrote: On Wed, Apr 09, 2014 at 10:23:32AM -0600, Jens Axboe wrote: This should go into block/blk-mq-tag.h. Ok. We might as well leave this, the mtip32xx conversion ends up using it. So if we pull it now, it'll just be reintroduced shortly. It's back

Re: [PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-04-09 Thread Jens Axboe
On 03/31/2014 08:46 AM, Christoph Hellwig wrote: diff --git a/block/blk-mq.h b/block/blk-mq.h index 238379a..eca3a47 100644 --- a/block/blk-mq.h +++ b/block/blk-mq.h @@ -1,6 +1,24 @@ #ifndef INT_BLK_MQ_H #define INT_BLK_MQ_H +#include + +/* + * Tag address space map. + */ +struct

Re: [PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-04-09 Thread Jens Axboe
On 03/31/2014 08:46 AM, Christoph Hellwig wrote: diff --git a/block/blk-mq.h b/block/blk-mq.h index 238379a..eca3a47 100644 --- a/block/blk-mq.h +++ b/block/blk-mq.h @@ -1,6 +1,24 @@ #ifndef INT_BLK_MQ_H #define INT_BLK_MQ_H +#include linux/percpu_ida.h + +/* + * Tag address space map. + */

[PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-03-31 Thread Christoph Hellwig
This is in preparation for allowing to share the tags, and thus request allocation between multiple queues. Also remove blk_mq_tag_to_rq, as it was unused and thus untestable. If we need it back it can easil be re-added as a non-inline function. Note that we also now straight out fail queue

[PATCH 3/4] blk-mq: move request structures into struct blk_mq_tags

2014-03-31 Thread Christoph Hellwig
This is in preparation for allowing to share the tags, and thus request allocation between multiple queues. Also remove blk_mq_tag_to_rq, as it was unused and thus untestable. If we need it back it can easil be re-added as a non-inline function. Note that we also now straight out fail queue