Re: [PATCH 3/4] doc: dt: pwm: add binding for ChromeOS EC PWM

2016-06-02 Thread Brian Norris
Hi, After some more thought, a small change in plans. On Tue, May 31, 2016 at 06:10:59PM -0700, Brian Norris wrote: > On Sat, May 28, 2016 at 10:00:45PM -0700, Gwendal Grignou wrote: > > Instead of using device tree, assuming you have firmware control, > > another way could be to add a firmware f

Re: [PATCH 3/4] doc: dt: pwm: add binding for ChromeOS EC PWM

2016-05-31 Thread Brian Norris
Hi Gwendal, On Sat, May 28, 2016 at 10:00:45PM -0700, Gwendal Grignou wrote: (Top posting?) > Instead of using device tree, assuming you have firmware control, > another way could be to add a firmware feature: I do have firmware control, but I don't think that will be too necessary actually. >

Re: [PATCH 3/4] doc: dt: pwm: add binding for ChromeOS EC PWM

2016-05-28 Thread Gwendal Grignou
Instead of using device tree, assuming you have firmware control, another way could be to add a firmware feature: for instance, there is one EC_FEATURE_PWM_FAN, the fan PWM, one for the keyboard lightning as well. (see num ec_feature_code) By adding one more, you let cros_ec_dev load the platform d

[PATCH 3/4] doc: dt: pwm: add binding for ChromeOS EC PWM

2016-05-27 Thread Brian Norris
The ChromeOS Embedded Controller can support controlling its attached PWMs via its host-command interface. The number of supported PWMs varies on a per-board basis, so we define a "google,max-pwms" property to handle this. And because the EC only allows specifying the duty cycle and not the period,