Re: [PATCH 3/4] exec: move the final allow_write_access/fput into free_bprm()

2013-11-23 Thread Kees Cook
On Fri, Nov 22, 2013 at 9:54 AM, Oleg Nesterov wrote: > Both success/failure paths cleanup bprm->file, we can move this > code into free_bprm() to simlify and cleanup this logic. Nice, yeah, this looks right. Acked-by: Kees Cook -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from

Re: [PATCH 3/4] exec: move the final allow_write_access/fput into free_bprm()

2013-11-23 Thread Kees Cook
On Fri, Nov 22, 2013 at 9:54 AM, Oleg Nesterov o...@redhat.com wrote: Both success/failure paths cleanup bprm-file, we can move this code into free_bprm() to simlify and cleanup this logic. Nice, yeah, this looks right. Acked-by: Kees Cook keesc...@chromium.org -Kees -- Kees Cook Chrome OS

Re: [PATCH 3/4] exec: move the final allow_write_access/fput into free_bprm()

2013-11-22 Thread KOSAKI Motohiro
(11/22/2013 12:54 PM), Oleg Nesterov wrote: > Both success/failure paths cleanup bprm->file, we can move this > code into free_bprm() to simlify and cleanup this logic. > > Signed-off-by: Oleg Nesterov Acked-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 3/4] exec: move the final allow_write_access/fput into free_bprm()

2013-11-22 Thread Oleg Nesterov
Both success/failure paths cleanup bprm->file, we can move this code into free_bprm() to simlify and cleanup this logic. Signed-off-by: Oleg Nesterov --- fs/exec.c | 20 +--- 1 files changed, 5 insertions(+), 15 deletions(-) diff --git a/fs/exec.c b/fs/exec.c index

[PATCH 3/4] exec: move the final allow_write_access/fput into free_bprm()

2013-11-22 Thread Oleg Nesterov
Both success/failure paths cleanup bprm-file, we can move this code into free_bprm() to simlify and cleanup this logic. Signed-off-by: Oleg Nesterov o...@redhat.com --- fs/exec.c | 20 +--- 1 files changed, 5 insertions(+), 15 deletions(-) diff --git a/fs/exec.c b/fs/exec.c

Re: [PATCH 3/4] exec: move the final allow_write_access/fput into free_bprm()

2013-11-22 Thread KOSAKI Motohiro
(11/22/2013 12:54 PM), Oleg Nesterov wrote: Both success/failure paths cleanup bprm-file, we can move this code into free_bprm() to simlify and cleanup this logic. Signed-off-by: Oleg Nesterov o...@redhat.com Acked-by: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com -- To unsubscribe from