Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-22 Thread Jaegeuk Kim
rnel@vger.kernel.org; > > linux-f2fs-de...@lists.sourceforge.net > > Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in > > truncate_blocks > > > > On Wed, Aug 20, 2014 at 10:07:04AM +0800, Chao Yu wrote: > > > > -Original Message-

RE: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-22 Thread Chao Yu
> To: Chao Yu > > > Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; > > > linux-f2fs-de...@lists.sourceforge.net > > > Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in > > > truncate_blocks > > > > > >

RE: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-22 Thread Chao Yu
; linux-f2fs-de...@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks On Tue, Aug 19, 2014 at 04:04:11PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent

Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-22 Thread Jaegeuk Kim
...@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks On Wed, Aug 20, 2014 at 10:07:04AM +0800, Chao Yu wrote: -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, August 20, 2014 12:58 AM To: Chao

Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-21 Thread Jaegeuk Kim
.kernel.org; > > linux-f2fs-de...@lists.sourceforge.net > > Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in > > truncate_blocks > > > > On Tue, Aug 19, 2014 at 04:04:11PM +0800, Chao Yu wrote: > > > Hi Jaegeuk, > > > > > > > ---

Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-21 Thread Jaegeuk Kim
...@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks On Tue, Aug 19, 2014 at 04:04:11PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, August 16, 2014 6:04 AM

RE: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-19 Thread Chao Yu
6, 2014 6:04 AM > > > To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; > > > linux-f2fs-de...@lists.sourceforge.net > > > Cc: Jaegeuk Kim > > > Subject: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks > > > > > > The init_

Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-19 Thread Jaegeuk Kim
.kernel.org; > > linux-f2fs-de...@lists.sourceforge.net > > Cc: Jaegeuk Kim > > Subject: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks > > > > The init_inode_metadata calls truncate_blocks when error is occurred. > > The callers holds f2fs_lock_op, so w

RE: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-19 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Saturday, August 16, 2014 6:04 AM > To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-de...@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-

RE: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-19 Thread Chao Yu
-de...@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks The init_inode_metadata calls truncate_blocks when error is occurred. The callers holds f2fs_lock_op, so we should not call it again in truncate_blocks. Nice

RE: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-19 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, August 16, 2014 6:04 AM To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 3/4] f2fs: avoid

Re: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-19 Thread Jaegeuk Kim
Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 3/4] f2fs: avoid double lock in truncate_blocks The init_inode_metadata calls truncate_blocks when error is occurred. The callers holds f2fs_lock_op, so we should not call it again in truncate_blocks. Nice catch! Your solution is a good way

[PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-15 Thread Jaegeuk Kim
The init_inode_metadata calls truncate_blocks when error is occurred. The callers holds f2fs_lock_op, so we should not call it again in truncate_blocks. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 2 +- fs/f2fs/dir.c| 2 +- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 13

[PATCH 3/4] f2fs: avoid double lock in truncate_blocks

2014-08-15 Thread Jaegeuk Kim
The init_inode_metadata calls truncate_blocks when error is occurred. The callers holds f2fs_lock_op, so we should not call it again in truncate_blocks. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c | 2 +- fs/f2fs/dir.c| 2 +- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c