On Fri, Apr 12, 2013 at 1:09 PM, Michael Brunner wrote:
>> (...)
>> > +struct kempld_gpio_data {
>> > + struct gpio_chipchip;
>> > + int irq;
>> > + struct kempld_device_data *pld;
>> > + uint16_t
Hi Linus,
As this code is from me I will comment on your review.
On Wed, 10 Apr 2013 22:45:51 +0200
Linus Walleij wrote:
(...)
> Trying to do some real review...
>
> (...)
> > +++ b/drivers/gpio/gpio-kempld.c
> > +#include
>
> Is this used?
Actually not, this can be removed.
> >
Hi Linus,
As this code is from me I will comment on your review.
On Wed, 10 Apr 2013 22:45:51 +0200
Linus Walleij linus.wall...@linaro.org wrote:
(...)
Trying to do some real review...
(...)
+++ b/drivers/gpio/gpio-kempld.c
+#include linux/acpi.h
Is this used?
Actually not,
On Fri, Apr 12, 2013 at 1:09 PM, Michael Brunner mi...@gmx.de wrote:
(...)
+struct kempld_gpio_data {
+ struct gpio_chipchip;
+ int irq;
+ struct kempld_device_data *pld;
+ uint16_tmask;
On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser
wrote:
> From: Michael Brunner
>
> Add gpio support for the on-board PLD found on some Kontron embedded
> modules.
>
> Signed-off-by: Michael Brunner
> Signed-off-by: Kevin Strasser
Trying to do some real review...
(...)
> +++
On Tue, Apr 9, 2013 at 6:41 PM, Guenter Roeck wrote:
> On Tue, Apr 09, 2013 at 10:46:15AM +0200, Linus Walleij wrote:
>> On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser
>> wrote:
>>
>> > From: Michael Brunner
>> >
>> > Add gpio support for the on-board PLD found on some Kontron embedded
>> >
On Tue, Apr 9, 2013 at 6:41 PM, Guenter Roeck li...@roeck-us.net wrote:
On Tue, Apr 09, 2013 at 10:46:15AM +0200, Linus Walleij wrote:
On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser
kevin.stras...@linux.intel.com wrote:
From: Michael Brunner michael.brun...@kontron.com
Add gpio support
On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser
kevin.stras...@linux.intel.com wrote:
From: Michael Brunner michael.brun...@kontron.com
Add gpio support for the on-board PLD found on some Kontron embedded
modules.
Signed-off-by: Michael Brunner michael.brun...@kontron.com
Signed-off-by:
On Tue, Apr 09, 2013 at 10:46:15AM +0200, Linus Walleij wrote:
> On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser
> wrote:
>
> > From: Michael Brunner
> >
> > Add gpio support for the on-board PLD found on some Kontron embedded
> > modules.
> >
> > Signed-off-by: Michael Brunner
> >
On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser
wrote:
> From: Michael Brunner
>
> Add gpio support for the on-board PLD found on some Kontron embedded
> modules.
>
> Signed-off-by: Michael Brunner
> Signed-off-by: Kevin Strasser
This looks very generic, setting and clearing bits in bytesized
On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser
kevin.stras...@linux.intel.com wrote:
From: Michael Brunner michael.brun...@kontron.com
Add gpio support for the on-board PLD found on some Kontron embedded
modules.
Signed-off-by: Michael Brunner michael.brun...@kontron.com
Signed-off-by:
On Tue, Apr 09, 2013 at 10:46:15AM +0200, Linus Walleij wrote:
On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser
kevin.stras...@linux.intel.com wrote:
From: Michael Brunner michael.brun...@kontron.com
Add gpio support for the on-board PLD found on some Kontron embedded
modules.
From: Michael Brunner
Add gpio support for the on-board PLD found on some Kontron embedded
modules.
Signed-off-by: Michael Brunner
Signed-off-by: Kevin Strasser
---
drivers/gpio/Kconfig| 22 ++
drivers/gpio/Makefile |2 +
drivers/gpio/gpio-kempld.c | 476
From: Michael Brunner michael.brun...@kontron.com
Add gpio support for the on-board PLD found on some Kontron embedded
modules.
Signed-off-by: Michael Brunner michael.brun...@kontron.com
Signed-off-by: Kevin Strasser kevin.stras...@linux.intel.com
---
drivers/gpio/Kconfig| 22 ++
14 matches
Mail list logo
